Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(feedback): Improve feedback error message #12647

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Conversation

c298lee
Copy link
Member

@c298lee c298lee commented Jun 25, 2024

Fix error message colour back to red. Also updated the default error message to include information about network issues and ad blockers since ad blockers can result in a type error which has no status code.

@c298lee c298lee requested a review from a team as a code owner June 25, 2024 23:34
Copy link
Contributor

github-actions bot commented Jun 25, 2024

size-limit report 📦

Path Size
@sentry/browser 22.22 KB (0%)
@sentry/browser (incl. Tracing) 33.31 KB (0%)
@sentry/browser (incl. Tracing, Replay) 69.09 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.42 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.15 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.75 KB (-0.02% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.61 KB (-0.02% 🔽)
@sentry/browser (incl. metrics) 26.5 KB (0%)
@sentry/browser (incl. Feedback) 38.86 KB (-0.04% 🔽)
@sentry/browser (incl. sendFeedback) 26.85 KB (-0.02% 🔽)
@sentry/browser (incl. FeedbackAsync) 31.45 KB (0%)
@sentry/react 24.97 KB (0%)
@sentry/react (incl. Tracing) 36.36 KB (0%)
@sentry/vue 26.33 KB (0%)
@sentry/vue (incl. Tracing) 35.17 KB (0%)
@sentry/svelte 22.36 KB (0%)
CDN Bundle 23.42 KB (0%)
CDN Bundle (incl. Tracing) 35.05 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.18 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.38 KB (-0.01% 🔽)
CDN Bundle - uncompressed 68.8 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.66 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 214.13 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 226.84 KB (+0.03% 🔺)
@sentry/nextjs (client) 36.24 KB (0%)
@sentry/sveltekit (client) 33.95 KB (0%)
@sentry/node 132.44 KB (0%)
@sentry/node - without tracing 91.86 KB (-0.01% 🔽)
@sentry/aws-serverless 118.45 KB (0%)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants