feat(core): Return client from init method #12585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chargome
requested review from
a team,
AbhiPrasad and
s1gr1d
and removed request for
a team
AbhiPrasad
reviewed
Jun 20, 2024
packages/node/src/sdk/index.ts
Outdated
| @@ -98,14 +98,14 @@ function shouldAddPerformanceIntegrations(options: Options): boolean { | |||
| /** | |||
| * Initialize Sentry for Node. | |||
| */ | |||
| export function init(options: NodeOptions | undefined = {}): void { | |||
| export function init(options: NodeOptions | undefined = {}): NodeClient { | |||
There was a problem hiding this comment.
m: Although we always return a top-level client here, making this NodeClient | undefined gives us more flexibility in the future for top-level API without making breaking changes. It also allows us to align the type signature everywhere.
There was a problem hiding this comment.
Yes you're right, will update that!
size-limit report 📦
|
mydea
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
I think it would be nice to eventually get to a place where this does not need to return Client | undefined as it makes stuff less ergonomic for users, but it's fine for now and we can make the return type stricter later if we want. So let's go with this for now! 👍
chargome
force-pushed
the
cg/return-client-from-init
branch
from
34d8355
to
febc201
Compare
6 tasks
This was referenced Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12495