Esanders (Ed Sanders)
Principal Software Engineer, Editing

Projects (18)

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 27 2014, 6:03 PM (507 w, 3 d)
Availability
Busy Busy until Aug 31.
IRC Nick
edsanders
LDAP User
Esanders
MediaWiki User
ESanders (WMF) [ Global Accounts ]

Recent Activity

Mon, Jul 15

Esanders renamed T369996: "Topic not found" toast message when going to de.m.wiki main page with non-existing anchor link from error message at specific URL to "topic not found" error message shown on dewiki main page.
Mon, Jul 15, 10:26 AM · DiscussionTools
Esanders updated subscribers of T368598: Pasting into text styling on VisualEditor turns it into a cloud character.
Mon, Jul 15, 10:12 AM · Editing-team, VisualEditor-CopyPaste, VisualEditor

Wed, Jul 10

Esanders added a comment to T366400: MediaWiki core's docs don't show members inherited from OOUI.

The plugin we use for this only uses classes found in the current codebase:

Wed, Jul 10, 12:48 PM · OOUI, MediaWiki-Documentation, JSDoc WMF theme

Mon, Jul 1

Esanders added a project to T359815: Enable Visual Editor on Wikipedia namespace on Armenian Wikipedia: Editing-team (Kanban Board).
Mon, Jul 1, 4:08 PM · Editing-team (Kanban Board), Wikimedia-Site-requests, VisualEditor

Thu, Jun 27

Esanders created T368631: Can't `@see` an external type.
Thu, Jun 27, 3:53 PM · Patch-For-Review, JSDoc WMF theme
Esanders created T368625: Can't link to an external method.
Thu, Jun 27, 3:04 PM · Patch-For-Review, JSDoc WMF theme
Esanders created T368623: Types referenced in a {@link} and not processed by the externals plugin.
Thu, Jun 27, 2:31 PM · Patch-For-Review, JSDoc WMF theme

Wed, Jun 26

Esanders added a comment to T368534: Give MobileFrontend classes a virtual prefix in documentation.

Note also that with an agreed prefixMap it could be set upstream in jsdoc-wmf-theme so extension never had to re-define it.

Wed, Jun 26, 8:27 PM · Web-Team-Backlog (Needs Prioritization (Tech)), MobileFrontend
Esanders created T368534: Give MobileFrontend classes a virtual prefix in documentation.
Wed, Jun 26, 1:28 PM · Web-Team-Backlog (Needs Prioritization (Tech)), MobileFrontend
Esanders updated subscribers of T368424: VisualEditor: Use null prototype for objects, to guard against prototype pollution.
Wed, Jun 26, 11:45 AM · Technical-Debt, Editing-team (Kanban Board), Patch-For-Review, VisualEditor
Esanders added a comment to T359182: Instrument permalink timestamps.

Data shows clicks to permalink timestamps on both non-talk (or subject) pages and talk pages. Is this possible/expected?

Wed, Jun 26, 10:27 AM · Editing-team (Kanban Board), Product-Analytics (Kanban), Verified, Goal, MW-1.42-notes (1.42.0-wmf.22; 2024-03-12), Patch-For-Review, DiscussionTools
Esanders added a comment to T368086: Talk highlight doesn't work in dark mode.

We use mix-blend-mode: darken so the text stays black under the highlight. There isn't a blend mode that works well in dark and light mode, so you'll need to use lighten in dark mode. mix-blend-mode is used in a few place so perhaps you will want to make this a re-usable token.

Wed, Jun 26, 10:02 AM · Verified, DiscussionTools, Web-Team-Backlog (FY2024-25 Q1 Sprint 1), MW-1.43-notes (1.43.0-wmf.12; 2024-07-02), FY2023-24-WE 2.1 Typography and palette customizations
Esanders added a comment to T367559: Cloud VPS "visualeditor" project Buster deprecation.

Deleted

Wed, Jun 26, 8:22 AM · Editing-team, Cloud-VPS (Debian Buster Deprecation)
Esanders added a comment to T368483: Regression: Global invert broke VisualEditor "Add a link" workflow.

Since T345281 all non-inverting images are marked with mw-no-invert, or cdx-no-invert.

Wed, Jun 26, 8:09 AM · Verified, MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Web-Team-Backlog (FY2024-25 Q1 Sprint 1), Editing-team (Kanban Board), Regression, VisualEditor

Tue, Jun 25

Esanders renamed T95388: Try to find link in archive.org when direct scraping fails from Try to find link in archive.org for 520 page to Try to find link in archive.org when direct scraping fails.
Tue, Jun 25, 4:16 PM · Patch-For-Review, Internet-Archive, VisualEditor, Citoid
Esanders updated the task description for T368081: Upgrade jsdoc-wmf-themes in production to 1.1.0, merge prefixMap with prefixMapIgnore, and simplify plugins.
Tue, Jun 25, 3:02 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), JSDoc WMF theme
Esanders created T368378: Excessing paragraph after last paragraph in multi-line reference preview.
Tue, Jun 25, 9:44 AM · Regression, VisualEditor, Desktop Improvements (Vector 2022)
Esanders reopened T362939: [Design] Fix unintended vertical spacing behavior in Minerva and Vector as "Open".

Then, boxes should be evenly spaced from top and bottom (p:last-child { margin-bottom: 0.5em }):

image.png (225×1 px, 24 KB)

Yes, boxes should have equal top and bottom margins like the message component in codex.

Tue, Jun 25, 9:33 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 5), Community Feedback (Web), Patch-For-Review, FY2023-24-WE 2.1 Typography and palette customizations
Esanders reopened T362939: [Design] Fix unintended vertical spacing behavior in Minerva and Vector, a subtask of T362148: Deploy reading accessibility settings menu and new typography defaults to remaining Wikipedias, as Open.
Tue, Jun 25, 9:32 AM · Web-Team-Backlog (FY2023-24 Q4 Sprint 5), FY2023-24-WE 2.1 Typography and palette customizations
Esanders added a project to T368302: Nested list items are displayed too close to their parent list item in VisualEditor in Vector-2022: Regression.
Tue, Jun 25, 9:25 AM · Editing-Team-Request, Web-Team-Backlog, Regression, Desktop Improvements (Vector 2022), VisualEditor
Esanders added a comment to T368302: Nested list items are displayed too close to their parent list item in VisualEditor in Vector-2022.

Looks like https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/1036715 which introduces negative margins.

Tue, Jun 25, 9:24 AM · Editing-Team-Request, Web-Team-Backlog, Regression, Desktop Improvements (Vector 2022), VisualEditor
Esanders added a comment to T368302: Nested list items are displayed too close to their parent list item in VisualEditor in Vector-2022.

Possibly related to T362939

Tue, Jun 25, 9:22 AM · Editing-Team-Request, Web-Team-Backlog, Regression, Desktop Improvements (Vector 2022), VisualEditor

Mon, Jun 24

Esanders added a comment to T368081: Upgrade jsdoc-wmf-themes in production to 1.1.0, merge prefixMap with prefixMapIgnore, and simplify plugins.

You can prepare the upgrade patches before we do the release by installing from gerrit (npm i --save-dev git+https://gerrit.wikimedia.org/r/jsdoc/wmf-theme#refs/changes/47/1041147/2)

Mon, Jun 24, 3:49 PM · Patch-For-Review, MW-1.43-notes (1.43.0-wmf.15; 2024-07-23), JSDoc WMF theme

Sat, Jun 22

Esanders added a comment to T368179: VisualEditor warning about blocked external link can be skipped too easily (even accidentally).

(executeAction is called directly quite rarely, so I doubt we would have a problem with the above breaking change: https://codesearch.wmcloud.org/search/?q=executeAction%5C%28&files=&excludeFiles=&repos=#Extension:VisualEditor)

Sat, Jun 22, 10:04 AM · Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
Esanders added a comment to T368179: VisualEditor warning about blocked external link can be skipped too easily (even accidentally).
  1. We could fix this at the OOUI level, checking if there are visible actions, and if those actions are disabled. It would technically be a breaking change, although I don't know how likely it is that someone has deliberately programmatically triggered an action that is disabled in the UI. One could add an override to allow it to go through, or have it skip the UI check by default.
Sat, Jun 22, 10:01 AM · Editing-team (Kanban Board), VisualEditor-MediaWiki, VisualEditor
Esanders added a parent task for T368156: Support css grid in wikitable class: T368157: Support CSS grid in the same way as tables.
Sat, Jun 22, 9:42 AM · MediaWiki-General
Esanders added a subtask for T368157: Support CSS grid in the same way as tables: T368156: Support css grid in wikitable class.
Sat, Jun 22, 9:42 AM · VisualEditor

Fri, Jun 21

Esanders added a comment to T368102: jquery.textSelection behavior changed when given `undefined` in command options.

but the functionality is known to other people

Fri, Jun 21, 2:38 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, MediaWiki-User-Interface (active libraries), Regression
Esanders added a comment to T368102: jquery.textSelection behavior changed when given `undefined` in command options.

I did not open all rMW2af1c3c901a6117fe062e1fd88c0146cffa1481d but I could imagine that the same bug has been injected in many many codes.

Fri, Jun 21, 12:21 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, MediaWiki-User-Interface (active libraries), Regression
Esanders added a comment to T368102: jquery.textSelection behavior changed when given `undefined` in command options.

Looking at the code I can't see where this might be going wrong either. In T368029, there was an issue with the first argument being undefined, but in this case the first argument is a literal object, and only the second argument can be undefined, which isn't a problem.

> Object.assign( {a: 1}, undefined )
< {a: 1}
Fri, Jun 21, 12:04 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, MediaWiki-User-Interface (active libraries), Regression
Esanders added a comment to T368102: jquery.textSelection behavior changed when given `undefined` in command options.

When on source text editing something is marked and string overwriting is requested, undefined is additionally inserted into wikitext after selection end.

Fri, Jun 21, 12:00 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, MediaWiki-User-Interface (active libraries), Regression
Esanders claimed T368102: jquery.textSelection behavior changed when given `undefined` in command options.
Fri, Jun 21, 11:58 AM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Patch-For-Review, MediaWiki-User-Interface (active libraries), Regression
Esanders added a project to T368119: It is no longer possible to click links within visualeditor's popupWidget: Regression.

Users expect to be able to follow the links in the preview - to check on the source while editing. Link contexts work the same way. If you feel this functionality needs to change we should file a task explicitly for that and discuss the pros and cons there.

Fri, Jun 21, 11:49 AM · User-notice, Verified, MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Editing-team (Kanban Board), Regression, VisualEditor-MediaWiki-References, VisualEditor

Thu, Jun 20

Esanders added a comment to T368082: Decide on the standard name for a JSDoc settings file: .jsdoc.json or jsdoc.json.

I've never really understood the hidden file standard (leading .) so happy to go without it. Other tools are inconsistent, so I don't think it matters too much which we pick:

  • .eslintrc.json
  • .stylelintrc.json
  • .bananaconfig.json
  • tsconf.json
  • package.json
  • bundlesize.config.json
Thu, Jun 20, 5:42 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), JSDoc WMF theme, Documentation
Esanders awarded T368029: Special:Notifications (partially?) broken a 100 token.
Thu, Jun 20, 5:38 PM · MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), User-Michael, Growth-Team (Sprint 16 (Growth Team)), Notifications, affects-translatewiki.net
Esanders awarded T368053: Remove build step from CodeMirror a Yellow Medal token.
Thu, Jun 20, 5:37 PM · Patch-For-Review, MediaWiki-extensions-CodeMirror
Esanders closed T360659: ve.collab: Host username gets copied to all clients as Resolved.
Thu, Jun 20, 2:32 PM · VisualEditor
Esanders added a comment to T364104: Automatically load plugins.

@Novem_Linguae : https://gerrit.wikimedia.org/r/c/jsdoc/wmf-theme/+/1041147

Thu, Jun 20, 2:25 PM · JSDoc WMF theme
Esanders created T368053: Remove build step from CodeMirror.
Thu, Jun 20, 2:13 PM · Patch-For-Review, MediaWiki-extensions-CodeMirror
Esanders closed T360662: ve.collab: Make it clear that usernames are controlled by clients and so not "trusted" as Resolved.
Thu, Jun 20, 12:47 PM · VisualEditor

Wed, Jun 19

Esanders added a comment to T350840: TypeError: Cannot read properties of null (reading 'parentNode') at ThreadItem.js.ThreadItem.static.newFromJSON.

Should be fixed by https://www.mediawiki.org/w/index.php?title=MediaWiki%3AGadget-tabbedwindow.js&diff=6588257&oldid=6583748

Wed, Jun 19, 2:50 PM · JavaScript, Wikimedia-production-error, DiscussionTools

Jun 17 2024

Esanders added a comment to T367639: "Topic could not be found" is shown sometimes on mediawiki.org docs page.

Should be fixed by https://www.mediawiki.org/w/index.php?title=MediaWiki%3AGadget-tabbedwindow.js&diff=6583748&oldid=6583747

Jun 17 2024, 12:45 PM · DiscussionTools
Esanders added a comment to T367639: "Topic could not be found" is shown sometimes on mediawiki.org docs page.

MediaWiki:Gadget-tabbedwindow.js sets a hash fragment for the current tab, but doesn't put an ID element in the actual document. It should pass an ID attribute to either the tabPanel or panelLayout.

Jun 17 2024, 12:35 PM · DiscussionTools
Esanders closed T52881: VisualEditor: Link input widget should suggest section links as Resolved.

Filed remaining work as T367739

Jun 17 2024, 12:27 PM · MW-1.42-notes (1.42.0-wmf.9; 2023-12-12), Patch-For-Review, VisualEditor-MediaWiki-Links, VisualEditor, VisualEditor-EditingTools, Browser-Support-Google-Chrome
Esanders updated subscribers of T367739: Section heading link suggestions should update when headings are added/edited.
Jun 17 2024, 12:26 PM · VisualEditor
Esanders updated the task description for T367739: Section heading link suggestions should update when headings are added/edited.
Jun 17 2024, 12:25 PM · VisualEditor
Esanders created T367739: Section heading link suggestions should update when headings are added/edited.
Jun 17 2024, 12:19 PM · VisualEditor
Esanders closed T97025: Detect browser compatibility in core as Declined.

See T367735: Drop the user-agent-based browser support list from VE (VisualEditorBrowserUnsupportedList)

Jun 17 2024, 12:14 PM · VisualEditor
Esanders closed T73728: VisualEditor: Copying text causes browser to scroll to the top of the page and move the cursor to the top in Safari as Resolved.
Jun 17 2024, 12:13 PM · VisualEditor-CopyPaste, VisualEditor, VisualEditor-ContentEditable, Browser-Support-Apple-Safari
Esanders closed T54008: VisualEditor: Gracefully handle when available browser UI features are disabled (rather than refusing to load) as Declined.

The extension in question doesn't exist anymore. I still don't think we need to support any future extension that kills essential web APIs.

Jun 17 2024, 12:11 PM · VisualEditor, VisualEditor-Initialisation
Esanders closed T59621: VisualEditor: Features not yet available in a certain browser (but working in others) should be grayed out/unselectable as Invalid.
Jun 17 2024, 12:11 PM · VisualEditor, VisualEditor-Initialisation
Esanders closed T53274: VisualEditor: Samsung browser fails the blacklist as Declined.

See T367735: Drop the user-agent-based browser support list from VE (VisualEditorBrowserUnsupportedList)

Jun 17 2024, 12:09 PM · VisualEditor-Initialisation, VisualEditor, VisualEditor-MediaWiki
Esanders closed T53274: VisualEditor: Samsung browser fails the blacklist, a subtask of T52781: VisualEditor: Browser blacklist issues (tracking), as Declined.
Jun 17 2024, 12:08 PM · User-Ryasmeen, VisualEditor pre-2015 work, VisualEditor, Tracking-Neverending, VisualEditor-Initialisation
Esanders closed T120012: Support Amazon Silk web browser as Declined.

As a chromium based browser this should work. If not it is unlikely to ever be prioritised.

Jun 17 2024, 12:07 PM · Epic, VisualEditor
Esanders closed T225600: VisualEditor doesn't need to explicitly exclude Opera < 12 any more as Declined.

See T367735: Drop the user-agent-based browser support list from VE (VisualEditorBrowserUnsupportedList)

Jun 17 2024, 12:05 PM · VisualEditor, VisualEditor-Initialisation, VisualEditor-MediaWiki
Esanders added a project to T367735: Drop the user-agent-based browser support list from VE (VisualEditorBrowserUnsupportedList): Technical-Debt.
Jun 17 2024, 12:03 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Technical-Debt, VisualEditor-MediaWiki, VisualEditor
Esanders created T367735: Drop the user-agent-based browser support list from VE (VisualEditorBrowserUnsupportedList).
Jun 17 2024, 12:03 PM · MW-1.43-notes (1.43.0-wmf.11; 2024-06-25), Technical-Debt, VisualEditor-MediaWiki, VisualEditor

Jun 14 2024

Esanders committed rEPHN0be97a799288: build: Update eslint-confg-wikimedia to 0.28.2 and autofix.
build: Update eslint-confg-wikimedia to 0.28.2 and autofix
Jun 14 2024, 4:07 PM

Jun 13 2024

Esanders added a comment to T367413: Minerva reference drawer should have a light background.

Unrelated to night mode issues this seems like a sensible fix, and is quite small change.

Jun 13 2024, 5:23 PM · Web-Team-Backlog, Patch-For-Review, MobileFrontend
Esanders added a comment to T367194: Citoid/Zotero: Create rate limiting configurable on a per site basis.

@akosiaris This is just a technical exploration at the moment, there is no timeline or prioritisation yet. Knowing that this would a first within our infrastructure is useful information, thanks.

Jun 13 2024, 4:48 PM · VisualEditor-MediaWiki-References, Editing-team (Kanban Board), VisualEditor, Citoid
Esanders added a comment to T366095: Deploy comment thanking to all wikis.

Is there instrumentation to understand the usage of this feature? I guess we could look at API usage of discussiontoolsthank and/or data associated with Echo notifications that comment thanking will generate?

Jun 13 2024, 4:43 PM · Editing-team (Deployments)
Esanders added a comment to T367441: Remove ResourceLoader debug mode v1.

Update eslint-config-wikimedia to default to commonjs mode

Jun 13 2024, 4:25 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
Esanders awarded T367441: Remove ResourceLoader debug mode v1 a Yellow Medal token.
Jun 13 2024, 4:21 PM · MediaWiki-Platform-Team, MediaWiki-ResourceLoader
Esanders added a comment to T367366: Failed to fetch notifications: Notifications fail to load.

Will need to be backported to wmf.9

Jun 13 2024, 3:01 PM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Notifications, Growth-Team, Wikidata
Esanders triaged T367366: Failed to fetch notifications: Notifications fail to load as Unbreak Now! priority.

Bisect blames my refactor at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/1038337

Jun 13 2024, 2:56 PM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Notifications, Growth-Team, Wikidata
Esanders renamed T367371: VisualEditor when using CodeMirror syntax highlighting is unreadable in dark mode from VisualEditor when using CodeEditor syntax highlighting isunreadable to VisualEditor when using CodeEditor syntax highlighting is unreadable in dark mode.
Jun 13 2024, 2:50 PM · Community-Tech, MediaWiki-extensions-CodeMirror, Web-Team-Backlog (FY2023-24 Q4 Sprint 5), VisualEditor
Esanders added a comment to T367413: Minerva reference drawer should have a light background.

PatchDemo: https://patchdemo.wmflabs.org/wikis/560a719650/w/index.php?title=Arsenal_F.C.&mobileaction=toggle_view_mobile

Jun 13 2024, 2:44 PM · Web-Team-Backlog, Patch-For-Review, MobileFrontend
Esanders updated subscribers of T367413: Minerva reference drawer should have a light background.

Quoting relevant parts of previous task:

Jun 13 2024, 2:44 PM · Web-Team-Backlog, Patch-For-Review, MobileFrontend
Esanders closed T129054: Math formulas can be unreadable in references in mobile view as Declined.

Filed as T367413

Jun 13 2024, 2:28 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 5), Patch-For-Review, Wikimedia-SVG-rendering, patch-welcome, Math, Google-Code-In-2016, MobileFrontend
Esanders added a comment to T357988: Reference drawer: Visited links have insufficient contrast in Minerva in light theme.

We should make the references drawer white per T367413.

Jun 13 2024, 2:28 PM · Web-Team-Backlog, WCAG-Level-AA, Accessibility, MinervaNeue
Esanders closed T129054: Math formulas can be unreadable in references in mobile view, a subtask of T287412: [GOAL, placeholder] Fix bugs relating to user experience in Minerva impacting mobile users, as Declined.
Jun 13 2024, 2:25 PM · Web-Team-Backlog, Goal, Epic
Esanders reopened T129054: Math formulas can be unreadable in references in mobile view as "Open".

There is still an open patch to make the reference drawer white, which I think should be merged. If we don't want to repurpose this task for it, can a new one be created.

Jun 13 2024, 2:25 PM · Web-Team-Backlog (FY2023-24 Q4 Sprint 5), Patch-For-Review, Wikimedia-SVG-rendering, patch-welcome, Math, Google-Code-In-2016, MobileFrontend
Esanders created T367413: Minerva reference drawer should have a light background.
Jun 13 2024, 2:25 PM · Web-Team-Backlog, Patch-For-Review, MobileFrontend
Esanders reopened T129054: Math formulas can be unreadable in references in mobile view, a subtask of T287412: [GOAL, placeholder] Fix bugs relating to user experience in Minerva impacting mobile users, as Open.
Jun 13 2024, 2:22 PM · Web-Team-Backlog, Goal, Epic
Esanders closed T367267: VisualEditor: "Read the user guide" cannot redirect to target page as Resolved.
Jun 13 2024, 2:18 PM · MW-1.43-notes (1.43.0-wmf.10; 2024-06-18), VisualEditor

Jun 12 2024

Novem_Linguae awarded T364104: Automatically load plugins a Like token.
Jun 12 2024, 11:31 PM · JSDoc WMF theme
Esanders added a comment to T365529: Convert 3D extension to ES6.

I would consider this done now. Feel free to close.

Jun 12 2024, 10:41 AM · 3D

Jun 11 2024

Krinkle awarded T364104: Automatically load plugins a Love token.
Jun 11 2024, 6:28 PM · JSDoc WMF theme
Esanders moved T366984: When one transclusion generates multiple table cells, VE counts it as a single table cell, and adds slugs for "missing" cells from Incoming to Code Review on the Editing-team (Kanban Board) board.
Jun 11 2024, 1:41 PM · Verified, Editing-team (Kanban Board), VisualEditor-MediaWiki-Templates, VisualEditor-Tables, VisualEditor
Esanders added a project to T366984: When one transclusion generates multiple table cells, VE counts it as a single table cell, and adds slugs for "missing" cells: Editing-team (Kanban Board).
Jun 11 2024, 1:41 PM · Verified, Editing-team (Kanban Board), VisualEditor-MediaWiki-Templates, VisualEditor-Tables, VisualEditor

Jun 10 2024

Esanders moved T366751: Link Check: Use edit check blocklist API to give feedback on links as well from Code Review to QA on the Editing-team (Kanban Board) board.
Jun 10 2024, 10:19 PM · Verified, Editing-team (Kanban Board), MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Goal, User-notice, EditCheck, VisualEditor-Links, VisualEditor
Esanders edited projects for T366751: Link Check: Use edit check blocklist API to give feedback on links as well, added: Editing-team (Kanban Board); removed Editing-team (Deployments).
Jun 10 2024, 10:18 PM · Verified, Editing-team (Kanban Board), MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), Goal, User-notice, EditCheck, VisualEditor-Links, VisualEditor
Esanders added a comment to T364595: Offer people an action they can take from within Citoid's error state to cite a source .

We're waiting for a few weeks to switch over to the version of the message with a separate header and body. Until then, it will look like this:

Jun 10 2024, 5:26 PM · Verified, MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), Goal, VisualEditor-MediaWiki-References, Editing-team (Kanban Board), VisualEditor, Citoid
Esanders added a comment to T367052: VE doesn't refresh "pending changes" toolbar button after save.

While the extra button is the responsibility of FlaggedRevs, it's VE who is responsible for refreshing all relevant parts of the UI after an edit happened.

Jun 10 2024, 1:23 PM · MediaWiki-extensions-FlaggedRevs, VisualEditor

Jun 7 2024

Esanders committed rEHIEc9d714fa89af: build: Update stylelint-config-wikimedia to 0.17.1.
build: Update stylelint-config-wikimedia to 0.17.1
Jun 7 2024, 7:21 PM
Esanders committed rEHIEab2ccfc7bd63: build: Update eslint-config-wikimedia to 0.28.0.
build: Update eslint-config-wikimedia to 0.28.0
Jun 7 2024, 7:21 PM

Jun 5 2024

Esanders added a comment to T366721: Add better error message for "No stashed content found".

Or "your edit session expired ..."

Jun 5 2024, 5:51 PM · Patch-For-Review, good first task, Parsoid (Tracking), Editing-team (Tracking), Parsoid-DOM, VisualEditor, VisualEditor-MediaWiki
Esanders moved T365974: Deploy talk page permalinks to en.wiki from Backlog to In Progress on the Editing-team (Deployments) board.
Jun 5 2024, 2:14 PM · Verified, Goal, Editing-team (Kanban Board), User-notice, DiscussionTools

Jun 3 2024

Esanders added a comment to T138401: Replace jsduck with JSDoc3 across all Wikimedia code bases.

Flow will be undeployed soon. I'm not sure it's worth working on. Just my 2c.

Jun 3 2024, 11:43 AM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ), Tech-Docs-Team, MW-1.40-notes (1.40.0-wmf.23; 2023-02-13), Patch-For-Review, Editing-team (Tracking), Epic, Technical-Debt (RW-Tech-Debt), Front-end-Standards-Group, Documentation
Esanders updated the task description for T364595: Offer people an action they can take from within Citoid's error state to cite a source .
Jun 3 2024, 11:37 AM · Verified, MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), Goal, VisualEditor-MediaWiki-References, Editing-team (Kanban Board), VisualEditor, Citoid
Esanders moved T364595: Offer people an action they can take from within Citoid's error state to cite a source from Doing to Code Review on the Editing-team (Kanban Board) board.
Jun 3 2024, 11:35 AM · Verified, MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), Goal, VisualEditor-MediaWiki-References, Editing-team (Kanban Board), VisualEditor, Citoid

May 31 2024

Esanders added a comment to T366220: Math formulas have a white background in dark mode on Minerva.

When we switch to MathML (T271001) this will not be a problem and we may want to consider undo-ing this rule .

May 31 2024, 5:48 PM · Verified, MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), Web-Team-Backlog (FY2024-25 Q1 Sprint 2), Patch-For-Review, Wikimedia-SVG-rendering, patch-welcome, Math, Google-Code-In-2016, MobileFrontend

May 30 2024

Esanders moved T364595: Offer people an action they can take from within Citoid's error state to cite a source from Ready to Be Worked On to Doing on the Editing-team (Kanban Board) board.
May 30 2024, 5:00 PM · Verified, MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), Goal, VisualEditor-MediaWiki-References, Editing-team (Kanban Board), VisualEditor, Citoid
Esanders updated subscribers of T366299: Investigate MediaWiki test failure (QUnit) - VisualEditor: prefixsearch ordering.

These tests were written by WMDE as part of their focus on the Template dialog. Not sure what project to tag this with now. CC @thiemowmde @Lina_Farid_WMDE

May 30 2024, 4:21 PM · MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), WMDE-TechWish-Sprint-2024-05-29, Unplanned-Sprint-Work, ci-test-error, VisualEditor
Esanders added a comment to T366220: Math formulas have a white background in dark mode on Minerva.

You'll want to use the full colour-rotating inversion rule, as math can contain colours.

May 30 2024, 11:54 AM · Verified, MW-1.43-notes (1.43.0-wmf.14; 2024-07-16), Web-Team-Backlog (FY2024-25 Q1 Sprint 2), Patch-For-Review, Wikimedia-SVG-rendering, patch-welcome, Math, Google-Code-In-2016, MobileFrontend
Esanders added a comment to T366214: "Uncaught Error: Cannot add a child to mwAlienMeta node" while removing text both in first heading and previous paragraph.

This doesn't appear to be a regression, and has been broken since we merged the linear data and metadata.

May 30 2024, 11:17 AM · Verified, Editing-team (Kanban Board), MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), VisualEditor-ContentEditable, VisualEditor
Esanders added a comment to T366214: "Uncaught Error: Cannot add a child to mwAlienMeta node" while removing text both in first heading and previous paragraph.

Minimal test case in VE standalone:
<p>Foo</p><meta><h2>Bar</h2>

May 30 2024, 11:13 AM · Verified, Editing-team (Kanban Board), MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), VisualEditor-ContentEditable, VisualEditor
Esanders added a comment to T366214: "Uncaught Error: Cannot add a child to mwAlienMeta node" while removing text both in first heading and previous paragraph.

The 'mwAlienMeta' in question is the auto-generated TOC marker that gets inserted after the first paragraph:
<meta property="mw:PageProp/toc" data-mw="{&quot;autoGenerated&quot;:true}" id="mwDw">

May 30 2024, 7:17 AM · Verified, Editing-team (Kanban Board), MW-1.43-notes (1.43.0-wmf.9; 2024-06-11), VisualEditor-ContentEditable, VisualEditor

May 29 2024

Esanders attached a referenced file: F54650197: image.png.
May 29 2024, 5:31 PM · DiscussionTools
Esanders added a comment to T366192: Better separation between same level comments in discussions.

For fr.wiki you can achieve what you need with :has selectors, which are supported by modern browsers:

dd:has( + dd ):not( :has( dl ) ) > span[data-mw-comment-end] {
	display: block;
	margin: 0.5em 0 0.5em -0.5em;
	border-top: 1px solid #a7d7f9;
}
May 29 2024, 5:28 PM · DiscussionTools