Refactor ILBFactory $lbFactory to IConnectionProvider $dbProvider in ServiceWiring of PageTriage
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Novem_Linguae
	May 2 2023, 9:49 AM

Description

Per a wikitech-l email

Refactor ILBFactory $lbFactory to IConnectionProvider $dbProvider in the ServiceWiring.php file.

Example gerrit patch

The instructions encourage changing both use and variable names.

Relevant codesearch

Details

Subject	Repo	Branch	Lines +/-
Add tests for maintenance scripts	mediawiki/extensions/PageTriage	master	+258 -128
Refactor ILBFactory to IConnectionProvider	mediawiki/extensions/PageTriage	master	+71 -27
Remove getLBFactory from maintenance scripts	mediawiki/extensions/PageTriage	master	+7 -22

Customize query in gerrit

Related Objects

Mentioned In: T348743: Migrate PageTriage to use a virtual database domain (remove LBFactory class)
T341312: Explore removing getPrimaryConnection and getReplicaConnection from PageTriageUtil of PageTriage

Event Timeline

Novem_Linguae created this task.May 2 2023, 9:49 AM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMay 2 2023, 9:49 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Novem_Linguae moved this task from Backlog to Priority technical debt on the PageTriage board.May 2 2023, 9:51 AM

• kostajh moved this task from Inbox to Triaged on the Growth-Team board.May 4 2023, 7:00 PM

Scardenasmolinar changed the task status from Open to In Progress.Jun 13 2023, 5:34 PM

Scardenasmolinar claimed this task.

Scardenasmolinar added a project: Moderator-Tools-Team (Kanban).

Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change 930742 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Refactor ILBFactory to IConnectionProvider

https://gerrit.wikimedia.org/r/930742

gerritbot added a project: Patch-For-Review.Jun 16 2023, 4:42 AM

Scardenasmolinar moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Jun 21 2023, 6:27 PM

• Samwalton9-WMF moved this task from Eng review to In Progress on the Moderator-Tools-Team (Kanban) board.Jun 22 2023, 2:38 PM

Scardenasmolinar moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Jun 22 2023, 8:25 PM

Change 934649 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Remove getLBFactory from maintenance scripts

https://gerrit.wikimedia.org/r/934649

Change 934650 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Add tests for maintenance scripts

https://gerrit.wikimedia.org/r/934650

Change 934649 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Remove getLBFactory from maintenance scripts

https://gerrit.wikimedia.org/r/934649

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 1 2023, 10:00 PM

Scardenasmolinar renamed this task from Refactor ILBFactory $lbFactory to IConnectionProvider $dbProvider in PageTriage to Refactor ILBFactory $lbFactory to IConnectionProvider $dbProvider in ServiceWiring of PageTriage.Jul 7 2023, 3:19 AM

Scardenasmolinar updated the task description. (Show Details)

Scardenasmolinar mentioned this in T341312: Explore removing getPrimaryConnection and getReplicaConnection from PageTriageUtil of PageTriage.Jul 7 2023, 3:24 AM

Change 930742 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Refactor ILBFactory to IConnectionProvider

https://gerrit.wikimedia.org/r/930742

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.17; 2023-07-11); removed MW-1.41-notes (1.41.0-wmf.16; 2023-07-04).Jul 7 2023, 1:00 PM

Change 934650 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Add tests for maintenance scripts

https://gerrit.wikimedia.org/r/934650

Maintenance_bot removed a project: Patch-For-Review.Jul 11 2023, 3:30 PM

Scardenasmolinar moved this task from Eng review to Done on the Moderator-Tools-Team (Kanban) board.Jul 11 2023, 3:41 PM

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.18; 2023-07-18); removed MW-1.41-notes (1.41.0-wmf.17; 2023-07-11).Jul 11 2023, 4:00 PM