11

Given the discussion here Deleting a comment (mine) shouldn't count as a comment vote as well as many other places on meta Wrong message "You may only submit a comment every five seconds" when deleting multiple comments or Confirmation dialog for deleting a comment does not appear twice etc Incorrect error text when deleting multiple comments within 5 seconds

Why is there no longer a dialog box when I go to1 delete a comment within five seconds of another comment action? Is this a regression bug?

1 oh it was funny to me :p

0

1 Answer 1

13

.comment-delete's click handler invokes submiteVote(), which makes an incorrect assumption about where you clicked. Specifically, it uses this.jComment.find(".comment-actions") to pass as the error target to .ajax()/StackExchange.helpers.showErrorPopup(), which only exists if the comment that you're "voting" on is not your own.

Since the target doesn't exist in this case, when the server returns the 409 response about rate-limiting your comment voting, the error dialog is appended to an empty jQuery set and therefore isn't visible to the user.

2
  • 1
    Oh good lord man, I knew you had an idea about the problem ...
    – jcolebrand
    Commented Jun 21, 2011 at 17:17
  • @jcolebrand Just needed a few minutes ;)
    – Tim Stone
    Commented Jun 21, 2011 at 17:18

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .