Timeline for Goodbye, Prettify. Hello highlight.js! Swapping out our Syntax Highlighter
Current License: CC BY-SA 4.0
12 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Oct 17, 2020 at 21:33 | comment | added | Josh Goebel | Well perhaps I shouldn't have said "no reason"... lol... SO is also a pretty huge service, and I'd call code highlighting a "critical feature"... so I'd imagine to some degree a known set of bugs with an existing library is better than unknown bugs in a new release. So if I was guessing I'd say "system stability" might be a concern that weighs into some of these decisions... perhaps. Although again minor releases and patch releases should be "pretty safe". :) | |
| Oct 17, 2020 at 21:30 | comment | added | Luuklag | @JoshGoebel I didn't imply there are reasons, from hearsay and exoerience it is known that staff takes a while to update these things. | |
| Oct 17, 2020 at 18:04 | comment | added | Josh Goebel | @luuklag There is no reason it needs to be so slow for minor/patch releases. We'll see if it improves going forward. A minor version bump of Highlight.js should be relatively trivial. Even if they wanted to allow time to us to find any issues in a new minor release usually that happens within a few days or week... and we do have a large number of tests. So if stability was a concern a policy of "wait ~1.5 weeks after minor release, then upgrade" should be quite safe. We'll see how it goes. I just released 10.3. | |
| Oct 12, 2020 at 12:44 | comment | added | Luuklag | I believe Josh maintains the highlight.js library. However SE would still need to update the version they are currently using then. This is a notourisly slow process. | |
| Oct 12, 2020 at 12:24 | history | edited | Erwin Brandstetter | CC BY-SA 4.0 |
added 334 characters in body
|
| Oct 7, 2020 at 17:21 | comment | added | Josh Goebel |
I have a PR to improve SQL to be less context dependent so will at least fix the fact that half the bottom of your snippet is detected as a string... Right now the ; in the middle is tripped it up because it reads that as the end of the statement.
|
|
| Oct 7, 2020 at 15:38 | comment | added | Erwin Brandstetter | @JoshGoebel: Dollar quoting is not part of the SQL standard. It's a (very convenient!) extension of the standard in Postgres. | |
| Oct 7, 2020 at 15:31 | comment | added | Josh Goebel | Is $$ quoting a part of ANSI SQL? | |
| Oct 7, 2020 at 15:25 | comment | added | Josh Goebel | I believe that is because SO is only using "SQL". They really should provide the individual SQL variants (such as PostgrSQL, etc) for best results. SQL is not intended to highlight ALL SQL variants well. If anything it's currently focused more on MySQL but long-term it should really be just ANSI SQL with people using the correct variant fo whatever server they are using. | |
| Oct 7, 2020 at 13:07 | history | edited | Erwin Brandstetter | CC BY-SA 4.0 |
add workaround issue
|
| Oct 7, 2020 at 12:58 | history | edited | Erwin Brandstetter | CC BY-SA 4.0 |
added 1 character in body
|
| Oct 7, 2020 at 12:38 | history | answered | Erwin Brandstetter | CC BY-SA 4.0 |