-
Notifications
You must be signed in to change notification settings - Fork 923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(plugin-sitemap): add sitemap plugin (close #337) #277
Conversation
Addtional: CI failed because of coverage, but since this plugin is deeply coupled with vuepress plugin api, it's hard to add some tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the same file structure as other plugins, i.e. only use node/index.ts
to import/export things, and use a node/sitemapPlugin.ts
file to declare the plugin
packages/@vuepress/plugin-sitemap/src/node/types/frontmatter.ts
Outdated
Show resolved
Hide resolved
Got it. i will update these days! |
@meteorlxy @Mister-Hope THANK You so much for doing great work is their any estimated release date that when this plugin will be released ? |
I am finishing all the changes, except I remain zh jsdocs in IMO, as we are providing both chinese and english docs, it's reasonable to keep both the languages in the final options provided to users to make sure they get full hints. |
Remove them, or we need to add translations to all other comments. |
it's happy to know that we will support support sitemap recently.And also appreciate @Mister-Hope ‘s sitemap plugin. |
@Mister-Hope Before you merge this can you please take a look at this also #353 |
I would prefer not to support any of the 2 fr in #353. For my personal reason, see #353 (comment) If you have different ideas and think any of them should be supported, just leave a message. |
why the pull request bog down? |
I am a postgraduate student, just kind of busy in real life. |
Any progress on the feature of sitemap? |
What are the chances that this lands in the 2.0 release? |
Any update here? |
I will finish it once my winter vacation begins, just busy being a postgraduate student studying quantum physics |
@meteorlxy Should be ready |
Some explaination:
|
I also think this is the right design, whatever this is a sitemap plugin. |
|
The missing option in docs is added. |
A description is added |
@meteorlxy Could you have another check? |
Looking forward to the sitemap plugin! |
I can confirm the sitemap plugin is working fine, pulled the code from the PR in as a "vendored" dependency and it works great for our site. |
@meteorlxy 👀大哥有空审一下吧,不要摸鱼了🤣 (For the rest, free to ignore this, I can't catch up a translation in English for 摸鱼) |
One feedback, I'd like to have the option to set the |
It's really a long time to wait |
You can use |
Any updates? Also, I found this site helpful: https://developers.google.com/search/docs/advanced/crawling/localized-versions#sitemap |
Hey u can use |
I was asking about this pull request, not about the other plugin. |
That plugin is published by me as the same with this pr. |
Are you going to rebase and fix conflicts, as this is the last item on the roadmap? |
|
||
::: warning Together with robots.txt | ||
|
||
Sitemap is basicly used by search engines, when using this plugin, you'd better ensure that you have a valid `rotbot.txt` in the `.vuepress/public` folder to allow search engines spiders to visit your site. A simplest robots.txt is as follows (allow all search engines to access all paths) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be robots.txt
|
||
::: warning 同步配置 robots.txt | ||
|
||
由于 Sitemap 面向搜索引擎,配合此插件使用时,你最好保证你在 `.vuepress/public` 文件夹下放置了有效的 `rotbot.txt`,以允许搜索引擎收录。一个最简单的 robots.txt 如下(允许所有搜索引擎访问所有路径) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be robots.txt
能不能早点合入并发布稳定版本?要不 VitePress 都出来了,它的价值空间就会被严重挤压,这么多努力就白费了。 |
@taozuhong You can take a look at vuejs/vitepress#548 VitePress might be VuePress 3 as a decision of Vue.js Team. So VuePress 2 has already been in an awkward position. That's why the stable version delayed a lot. |
I am updating |
Nice to see it, hope the plugins Api become more stable than last, make the plugin ecosystem release more power. |
Closing, this will be maintained speratedly |
Close #337