Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Learn Dashboard Invoice Page Line 20 should be a number #753

Open
Jakobud opened this issue Jun 19, 2024 · 0 comments
Open

Learn Dashboard Invoice Page Line 20 should be a number #753

Jakobud opened this issue Jun 19, 2024 · 0 comments

Comments

@Jakobud
Copy link

Jakobud commented Jun 19, 2024

Perhaps I'm incorrect about this, but I'm pretty sure that this should be of type number instead of string because later in the component page is used to derive the currentPage value. And according to the currentPage prop in the Table component, it's a number:

https://github.com/vercel/next-learn/blob/main/dashboard/final-example/app/ui/invoices/table.tsx#L12

VSCode calls out this problem as well:

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant