Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spaces around slash separators could be removed for more compression #1834

Closed
carols10cents opened this issue Sep 12, 2015 · 3 comments
Closed
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@carols10cents
Copy link

I noticed in this sass-spec test case that spaces around slash separators are preserved (note the difference in the output between property h and property m).

I would have expected the spaces to be removed, especially in compressed output.

Small test case on sassmeister with libsass (v3.2.5), current behavior seems to be the same with the different versions I tried (so this would be a feature request):

Input:

div {
  margin: 0/0/0/0;
  padding: 0 / 0 / 0 / 0;
}

Current compressed output:

div{margin:0/0/0/0;padding:0 / 0 / 0 / 0}

Expected compressed output:

div{margin:0/0/0/0;padding:0/0/0/0}

Please let me know if there's any other information that would be helpful! ❤️

@chriseppstein
Copy link

I assume you're using slashes for border-radius and not margin or padding since that's not legal css.

And yes, this would be a very minor improvement to our compression mode. / is not very common in CSS values. We'll happily accept a patch for this.

@chriseppstein chriseppstein added enhancement New feature or request help wanted Extra attention is needed labels Oct 7, 2015
@HamptonMakes
Copy link
Member

A case where sass-spec is born to model Ruby Sass parser, even when it's a "bug" (or semi-unintentional behavior). Eagle eyes badge for you on this one.

@nex3
Copy link
Contributor

nex3 commented Apr 6, 2018

Duplicate of #387

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
4 participants