Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shim-15 for CloudReady with renewed certificate #27

Closed
7 tasks done
nicholasbishop opened this issue Aug 20, 2018 · 2 comments
Closed
7 tasks done

shim-15 for CloudReady with renewed certificate #27

nicholasbishop opened this issue Aug 20, 2018 · 2 comments
Labels
accepted Submission is ready for sysdev

Comments

@nicholasbishop
Copy link
Contributor

Make sure you have provided the following information:

  • link to your code branch cloned from rhboot/shim-review in the form user/repo@tag
    neverware/shim-review@neverware-shim-20180820
  • completed README.md file with the necessary information
  • shim.efi to be signed
  • public portion of your certificate embedded in shim (the file passed to VENDOR_CERT_FILE)
  • any extra patches to shim via your own git tree or as files
  • any extra patches to grub via your own git tree or as files
  • build logs
What organization or people are asking to have this signed:

Neverware Inc. (https://www.neverware.com)

Version of shim:

15

Sysdev Submission ID:

Microsoft told us to get approval from the shim review board before submitting it to them.

What product or service is this for:

CloudReady

What's the justification that this really does need to be signed for the whole world to be able to boot it:

CloudReady is a Linux distro; we'd like to encourage people to boot our OS with secure boot enabled.

Note: our submission was previously reviewed here: #21. Unfortunately I had not realized our certificate was close to expiration. Our new shim build should be identical to the previous release, except with a renewed certificate valid until September 2020.

@cyphermox
Copy link
Collaborator

Looks fine to me. This reproduces exactly. Note that it looks like this build contains both your old and new certificates (there's evidence of the old expiration date in). If this isn't what you expect, you might want to resubmit.

I find this shim acceptable for signing.

1cb02fa0e3cbd5c6af4ddf4fb77a48fcbe527299db631bc8e82d8bb1e8d3e40a shimia32.efi
301861b782aa2e61cdd6f66cad3a55dc94a77f95ed143e58ce797bd6102f6302 shimx64.efi

@cyphermox cyphermox added the accepted Submission is ready for sysdev label Aug 24, 2018
@nicholasbishop
Copy link
Contributor Author

Thanks for reviewing. Could you expand on where/how you see evidence of the old certificate? I'm not sure how that would be getting in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Submission is ready for sysdev
3 participants