Skip to content
This repository has been archived by the owner on Mar 17, 2024. It is now read-only.

Reducing "Remote Desktop" Window cause client to briefly disconnect #830

Closed
azsde opened this issue Jun 10, 2020 · 8 comments
Closed

Reducing "Remote Desktop" Window cause client to briefly disconnect #830

azsde opened this issue Jun 10, 2020 · 8 comments
Labels
Milestone

Comments

@azsde
Copy link

azsde commented Jun 10, 2020

When viewing a client's remote desktop, reducing the window (by pressing the "-" button), cause the client to disconnect.

Steps to reproduce the behavior:

  1. Go to a connected client "Remote Desktop"
  2. Click on 'Start'
  3. Click on minimize button "-"
  4. Client is disconnected

Expected behavior

The remote desktop should keep going when the window is minized and the client should not be disconnected.

Server OS: Windows 10
Client OS: Windows 10
Server installed .NET Framework version: 4.8.03752
Client installed .NET Framework version: 4.8.04084
Quasar Version: 1.4.0

Build configuration: master

@ghost
Copy link

ghost commented Jun 10, 2020

you mean minimizing it? I'll look in the code to see what the click event does.

@azsde
Copy link
Author

azsde commented Jun 10, 2020

Yes sorry, minimizing.

In french we use another word, sorry for the mix-up.

@ghost
Copy link

ghost commented Jun 10, 2020

Yes sorry, minimizing.

In french we use another word, sorry for the mix-up.

No problem! I'm downloading the Quasar repository and will try to recreate the problem right now!

@ghost
Copy link

ghost commented Jun 11, 2020

I'm sorry I had to do something today but I'll make sure to respond in a couple hours or if I go to sleep when I wake up, sorry but it's 3 am right now.

@azsde
Copy link
Author

azsde commented Jun 11, 2020

I already provided those informations in the original post, I build Quasar myself based on the latest master commit.

@ghost
Copy link

ghost commented Jun 11, 2020

I know that is why I deleted the comment, I forgot that you need to specify those.

But anyways, here's what I found:

I'm looking into it and I noticed quasar closes the connection when the async receiver gets an error.
Could maybe happen due to the client sending incorrect data that causes an error to happen, Still looking into it

@ghost
Copy link

ghost commented Jun 11, 2020

Update:

My 3 main reasons for it happening are

Client sending incorrect data that can't be parsed so server drops connection
Server sending unsafe data that drops the connection
The amount of data sent is over the 5 megabyte limit MaxXor put in place.

@MaxXor MaxXor closed this as completed in 4c4cde4 Jun 12, 2020
@MaxXor
Copy link
Contributor

MaxXor commented Jun 12, 2020

@dogo99 It was much simpler, the local window size was set to (0,0) when minimized.

@azsde Thanks for the report. It's fixed in 4c4cde4

@MaxXor MaxXor added the bug label Jun 12, 2020
@MaxXor MaxXor added this to the 1.5.0 milestone Jun 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2 participants