-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
postinstall not being executed for pngquant-bin on MacOS #2853
Comments
I removed |
@llamerr why should this bug be removed ? I'm having the same issue. on Linux (our CI system) and MacOS. postinstall just doesn't seem to be reliably executed in v7. I'm noticing this across dozens of projects including eslint and electron. |
@burtonator I was thinking the issue was that I used force install, so maybe there were some incompatibilities, but that's still strange since I did not see any errors or warnings if I recall correctly. |
@llamerr I'm seeing this happen with other packages regardless of ci or install and regardless of package-lock.json or none. This is happening with electron, eslint, etc. Completely breaking our workflow. v6 has some serious bugs that we had to avoid so now we're on v7 but there are bugs on v7 we have to avoid too. |
@llamerr can you try replicating this problem on the latest version of |
I tried to reproduce it before upgrading, my current versions are:
and it seems on those versions it's already not reproducing, means working fine hm... actually I did not remove node_modules before trying it, but checking log, it seems that was done by npm
after npm update (can nvm be related?)
versions now are
and now bug is reproduced:
actually I see that on first try today it was |
I too am having issues with the postinstall script of a sub-dependency not being called. However when ran with yarn it works as expected. I have package A that has package B listed as a dependency, package B has a post install hook defined. When package B is installed directly by a project the post install script fires as expected, however when package A is installed the post install script for package B is not being called. I have passed I was initially encountering this on npm v8, so i updated to v9, but i am still facing the exact same issue. Node version: v18.14.2 |
Current Behavior:
One of subdependencies is
pngquant-bin
which havepostinstall
script which is not being executed nowExpected Behavior:
postinstall
should execute and generatenode_modules/pngquant-bin/vendor/pngquant
fileSteps To Reproduce:
Do
npm ci
for thispackage.json
filehttps://github.com/llamerr/npm-postinstall-bug
and check content of
ls node_modules/pngquant-bin/vendor/
as of now, it only contains
source
folder, butpngquant
file is missingNo errors or warnings reported by npm during install from what I see, https://github.com/llamerr/npm-postinstall-bug/blob/master/install.log
It probably started happening after yesterday's upgrade on MacOS. First after I did
rm -rf node_modules
andnpm ci
everything broke, so I checked updates and noticed new, upgraded my MacOS, brew, and command line tools. After everything started working again, I still was getting errors in my code which lead me to pngquant bin being missing. I'm using node fromnvm
if it matters, not sure if I did global packages update (I think I did? At least for some of them, will re-try now), but seems other stuff working fine.Environment:
OS: MacOS Big Sur 11.2.3 (20D91)
➜ npm-postinstall-bug git:(master) node -v
v14.15.3
➜ npm-postinstall-bug git:(master) npm -v
7.6.2
➜ npm-postinstall-bug git:(master) pkgutil --pkg-info=com.apple.pkg.CLTools_Executables
package-id: com.apple.pkg.CLTools_Executables
version: 12.4.0.0.1.1610135815
volume: /
location: /
install-time: 1615403944
groups: com.apple.FindSystemFiles.pkg-group
The text was updated successfully, but these errors were encountered: