-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] bundledDependencies
does not bundle relevant executables
#2491
Comments
What happens with npm v7.4.0? |
I tested it just now and the behavior is the same. The For a simpler repro, try a package file like "dependencies": {
"rimraf": "^3.0.2",
},
"bundleDependencies": [
"rimraf",
}
|
Having the same problem trying to run |
In the short term I've rewritten some of my |
@thw0rted |
Do you mean to make an artifact with |
npm If your bug is preproducible on If your issue was a feature request, please consider opening a new RRFC or RFC. If your issue was a question or other idea that was not CLI-specific, consider opening a discussion on our feedback repo |
I'm still getting this, I'm trying to bundle everything so it doesn't need to be installed on deployment but when using |
Current Behavior:
Bundled dependencies do not export executables when packing.
Expected Behavior:
npm pack
output should include scripts under.bin
to launch any executables provided by the bundled depdency.Steps To Reproduce:
lws
.bundledDependencies
npm pack
bundledDependency
undernode_modules
, but does not create a.bin
directory at all, and so the depdency's executable(s) will not be available.Environment:
Notes
I see from #1689 that
bundledDependencies
does not currently do special handling of the dep'spackage.json
, such as looking at thefiles
field. It's probably impractical / undesirable to process the wholebin
field frompackage.json
duringpack
, but at least it would make sense to check the existingnode_modules/.bin
for scripts that exactly match the package name and include those in the output.The text was updated successfully, but these errors were encountered: