Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] install/etc with --dry-run outputs misleading info (since it didn't actually do stuff) #1999

Open
isaacs opened this issue Oct 20, 2020 · 0 comments
Open

[BUG] install/etc with --dry-run outputs misleading info (since it didn't actually do stuff) #1999

isaacs opened this issue Oct 20, 2020 · 0 comments
Labels
Bug thing that needs fixing cmd:update related to `npm update` Priority 2 secondary priority issue Release 7.x work is associated with a specific npm 7 release

Comments

@isaacs
Copy link
Contributor

isaacs commented Oct 20, 2020

Current Behavior:

Installing (or other commands that call Arborist.reify(), like prune, dedupe, update, audit fix, etc.) using --dry-run produces output like this:

added 2 packages, removed 4 packages, and changed 2 packages in 12s

45 packages are looking for funding
  run `npm fund` for details

However, since the package tree was not actually reified, this output is misleading and not useful.

Expected Behavior:

Output a human-readable (or JSON in the case of --json) report of the changes that would have been made to the package tree, had it not been a --dry-run install.

Steps To Reproduce:

Run any reification command with --dry-run

Environment:

npm v7, all environments
@isaacs isaacs added Release 7.x work is associated with a specific npm 7 release Bug thing that needs fixing Needs Triage needs review for next steps labels Oct 20, 2020
@darcyclarke darcyclarke removed the Needs Triage needs review for next steps label Oct 20, 2020
@isaacs isaacs changed the title [BUG] install/etc with --dry-run outputs misleading info (since it didn't actually do stuff)` Oct 20, 2020
@wraithgar wraithgar mentioned this issue Jul 1, 2021
Closed
@ruyadorno ruyadorno added Priority 2 secondary priority issue cmd:update related to `npm update` labels Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing cmd:update related to `npm update` Priority 2 secondary priority issue Release 7.x work is associated with a specific npm 7 release
3 participants
@isaacs @ruyadorno @darcyclarke