Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

THREE.EllipseCurve is calculating start/end angles incorrectly #9282

Open
2 of 11 tasks
killroy42 opened this issue Jul 4, 2016 · 1 comment
Open
2 of 11 tasks

THREE.EllipseCurve is calculating start/end angles incorrectly #9282

killroy42 opened this issue Jul 4, 2016 · 1 comment

Comments

@killroy42
Copy link

killroy42 commented Jul 4, 2016

Description of the problem

With the latest update to THREE.EllipseCurve on the dev branch, the angle calculations are incorrect. You can no longer create a clockwise, full circle, as using 0/2Pi as the angles inverts/reverse the curve.

The problematic changes are in THREE.EllipseCurve.prototype.getPoint

Example:

// v-- full, counter-clockwise circle with origin on right
shape.absellipse(0, 0, 10, 10, 0, 2 * Math.PI, true);
 // v-- full, clockwise circle with origin on right
shape.absellipse(0, 0, 10, 10, 0, 2 * Math.PI + Number.EPSILON*2.1, true);

Expected behaviour is to get a clockwise circle when using 0/2Pi as start/end angles and true for the clockwise flag.

Three.js version
  • [x ] Dev
  • r78
  • ...
Browser
  • All of them
  • Chrome
  • Firefox
  • Internet Explorer
OS
  • All of them
  • Windows
  • Linux
  • Android
  • IOS
Hardware Requirements (graphics card, VR Device, ...)
@zz85
Copy link
Contributor

zz85 commented Jul 4, 2016

Relates to #8952 #9079

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants