Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema files for validation purposes #19

Closed
a2sheppy opened this issue Nov 4, 2016 · 3 comments · Fixed by #71
Closed

Add schema files for validation purposes #19

a2sheppy opened this issue Nov 4, 2016 · 3 comments · Fixed by #71
Labels
help wanted If you know something about this topic, we would love your help!

Comments

@a2sheppy
Copy link
Contributor

a2sheppy commented Nov 4, 2016

As part of our testing and validation before committing changes to the data, we should be using a tool such as ajv to not only validate that our JSON is structurally sound, but that it matches the schemas for each of the databases we have here.

This would go a long way toward helping to ensure that our data is properly formatted and will reduce the back-and-forth during the PR process.

@Elchi3
Copy link
Member

Elchi3 commented Jan 27, 2017

Should we work on JSON schemas for our CSS data to make sure our data is coherent before we publish to npm soon?

@a2sheppy
Copy link
Contributor Author

a2sheppy commented Jan 27, 2017 via email

@Elchi3 Elchi3 mentioned this issue Feb 10, 2017
@Elchi3 Elchi3 added the help wanted If you know something about this topic, we would love your help! label May 8, 2017
@lahmatiy
Copy link
Contributor

I've implemented initial schema validation, see #71.
Feedback is welcomed.

@Elchi3 Elchi3 closed this as completed in #71 Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted If you know something about this topic, we would love your help!
3 participants