Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with "Using Fetch": Add information about SameSite for cookies, when using credentials: 'include' #7025

Closed
msarris opened this issue Jul 19, 2021 · 0 comments · Fixed by #34278
Closed

Issue with "Using Fetch": Add information about SameSite for cookies, when using credentials: 'include' #7025

msarris opened this issue Jul 19, 2021 · 0 comments · Fixed by #34278
Labels
area: Fetch/XMLHttpRequest Content:WebAPI Web API docs effort: medium This task is a medium effort. help wanted If you know something about this topic, we would love your help!

Comments

@msarris
Copy link

msarris commented Jul 19, 2021

MDN URL: https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch

What information was incorrect, unhelpful, or incomplete?

There's no mention of the SameSite feature of cookies, which is important when using the credentials: 'include' option.

credentials: 'include' will have no effect when a cookie is fetched from another domain when SameSite=Lax or SameSite=Strict is set for the cookie (like a session cookie).

This took me quite a while to figure out and might have saved me time if it was mentioned on the page.
@teoli2003 teoli2003 added Content:HTTP HTTP docs Content:WebAPI Web API docs labels Jul 19, 2021
@sideshowbarker sideshowbarker added help wanted If you know something about this topic, we would love your help! 30 minute task labels Jul 19, 2021
@Rumyra Rumyra added needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. effort: medium This task is a medium effort. and removed 30 minute task labels Nov 25, 2021
@sideshowbarker sideshowbarker removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Jul 6, 2022
@Josh-Cena Josh-Cena mentioned this issue Jun 20, 2024
Merged
@Josh-Cena Josh-Cena removed the Content:HTTP HTTP docs label Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Fetch/XMLHttpRequest Content:WebAPI Web API docs effort: medium This task is a medium effort. help wanted If you know something about this topic, we would love your help!
5 participants
@sideshowbarker @Rumyra @teoli2003 @msarris @Josh-Cena