fix(html): remove ogv file from example #34514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OnkarRuikar
requested review from
chrisdavidmills
and removed request for
a team
github-actions
bot
added
Content:HTML
|
Preview URLs (comment last updated: 2024-07-04 06:52:26) |
chrisdavidmills
requested changes
Jul 1, 2024
There was a problem hiding this comment.
@OnkarRuikar The change you have made is perfectly fine, but you also need to update the corresponding description below the embedded example.
There are also some other mentions of OGG that you might want to review and update (for example in the "Server support for video" section).
github-actions
bot
added
size/s
chrisdavidmills
approved these changes
Jul 3, 2024
There was a problem hiding this comment.
@OnkarRuikar looking good! A couple more minor suggestions for you to look at, but I've decided to approve this
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
|
Awesome, thanks again @OnkarRuikar. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The demo fails on Chromium-based browsers as they only play the audio, not the video. Firefox doesn't play ogv at all.
The demo still remains relevant after removing the ogv source, because the next inline source avi isn't supported in any browser and they skip to mp4.