Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): add bracketed range notation #34670

Merged
merged 5 commits into from
Jul 18, 2024
Merged

fix(css): add bracketed range notation #34670

merged 5 commits into from
Jul 18, 2024

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner July 6, 2024 08:29
@OnkarRuikar OnkarRuikar requested review from chrisdavidmills and removed request for a team July 6, 2024 08:29
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Jul 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 6, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-07-18 12:31:24)
chrisdavidmills
chrisdavidmills requested changes Jul 6, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely work, thanks @OnkarRuikar! I've made a few comments for you to consider.
files/en-us/web/css/value_definition_syntax/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/value_definition_syntax/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/value_definition_syntax/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/value_definition_syntax/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/value_definition_syntax/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/value_definition_syntax/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/value_definition_syntax/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/value_definition_syntax/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/value_definition_syntax/index.md Outdated Show resolved Hide resolved
OnkarRuikar and others added 2 commits July 8, 2024 07:31
@OnkarRuikar @chrisdavidmills
Apply suggestions from code review
15dd86f 
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@OnkarRuikar
update curly entry in the table
fafd72d
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed size/s [PR only] 6-50 LoC changed labels Jul 18, 2024
chrisdavidmills
chrisdavidmills approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OnkarRuikar great stuff, this is now ready to go! I made a few grammar fixes while I was re-reviewing.
@chrisdavidmills chrisdavidmills merged commit fd54986 into mdn:main Jul 18, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_value_definition branch July 18, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
2 participants
@OnkarRuikar @chrisdavidmills