Add CloseWatcher reference pages #33910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
![github-actions[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Preview URLs (7 pages)(comment last updated: 2024-07-03 11:28:13) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
wbamberg
requested changes
Jun 7, 2024
lukewarlow
reviewed
Jun 24, 2024
|
Anything I can do to help get this across the line? It's shipped in Chrome and I have a webkit implementation so it'll hopefully be merged and released there soon, having these docs will be useful for developers to make use of it. |
|
@lukewarlow I'll take a look today. |
wbamberg
reviewed
Jul 2, 2024
Co-authored-by: wbamberg <will@bootbonnet.ca>
wbamberg
requested changes
Jul 2, 2024
Co-authored-by: wbamberg <will@bootbonnet.ca>
|
Thank you Will for reviewing this so thoroughly and making these docs so much better than my lazy initial pull request. I've accepted your suggestions. |
wbamberg
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
I'm happy it's helpful, Florian :).
I will approve this but won't merge in case @lukewarlow has comments, especially whether can do better with #33910 (comment). I don't think this is a blocker for getting the PR merged though.
lukewarlow
reviewed
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds references pages for
CloseWatcher.I reckon that my work here is quite minimal. Would be cool to write a bit more about this either in this PR or as a follow-up.
Motivation
This API is new and ships in Chromium based browsers in M126.
Fixes #34184
Additional details
Link to spec: https://html.spec.whatwg.org/multipage/interaction.html#the-closewatcher-interface
Related issues and pull requests
BCD: mdn/browser-compat-data#23207