Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#33618: clarify omitting <tbody> #34062

Merged
merged 3 commits into from
Jun 12, 2024
Merged

#33618: clarify omitting <tbody> #34062

merged 3 commits into from
Jun 12, 2024

Conversation

estelle
Copy link
Member

@estelle estelle commented Jun 11, 2024

hopefully fixes #33618
@estelle estelle requested a review from a team as a code owner June 11, 2024 19:20
@estelle estelle requested review from dipikabh and removed request for a team June 11, 2024 19:20
@github-actions github-actions bot added Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed labels Jun 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 11, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-06-12 18:28:38)
wbamberg
wbamberg requested changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't like "validly" and thought "may not work as expected or at all" was understating things. Also, we have an example of this in the page!
files/en-us/web/html/element/tbody/index.md Outdated Show resolved Hide resolved
@estelle @wbamberg
Update files/en-us/web/html/element/tbody/index.md
ce85d8e 
Co-authored-by: wbamberg <will@bootbonnet.ca>
@estelle estelle requested a review from wbamberg June 12, 2024 18:15
@estelle
Copy link
Member Author

estelle commented Jun 12, 2024

Thanks @wbamberg. I merged your suggestion.
wbamberg
wbamberg approved these changes Jun 12, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @estelle !
@wbamberg wbamberg merged commit af5eda8 into main Jun 12, 2024
9 checks passed
@wbamberg wbamberg deleted the estelle-patch-4 branch June 12, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTML Hypertext Markup Language docs size/xs [PR only] 0-5 LoC changed
2 participants
@estelle @wbamberg