-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
33549 text wrap style values #34036
33549 text wrap style values #34036
Conversation
Preview URLs (comment last updated: 2024-06-11 13:26:14) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these options cause wrapping. Doesn't that mean all of them mean text-wrap-mode: wrap
? If so we probably should mention it in a consistent way. For example they can all start with "Text is wrapped in a way that..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I strongly recommend getting rid of the "in the same way that text-wrap-mode: wrap;
" wording, unless I'm missing something. text-wrap-mode: wrap;
does not say anything about how text is wrapped, only that it's wrapped. The two properties work in combination. It's even already mentioned above:
When wrapping is allowed (see
text-wrap-mode
), thetext-wrap-style
property is specified as a single keyword chosen from the list of values below.
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks great
Description
Corrected the values of
text-wrap-style
Motivation
Report that the values were wrong and misleading issue 33549
Additional details
N/A
Related issues and pull requests
Fix #33549