Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

33549 text wrap style values #34036

Merged
merged 10 commits into from
Jun 11, 2024

Conversation

dletorey
Copy link
Contributor

@dletorey dletorey commented Jun 10, 2024

Description

Corrected the values of text-wrap-style

Motivation

Report that the values were wrong and misleading issue 33549

Additional details

N/A

Related issues and pull requests

Fix #33549

@dletorey dletorey requested a review from a team as a code owner June 10, 2024 11:18
@dletorey dletorey requested review from bsmth and removed request for a team June 10, 2024 11:18
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Jun 10, 2024
Copy link
Contributor

github-actions bot commented Jun 10, 2024

Preview URLs

(comment last updated: 2024-06-11 13:26:14)

Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these options cause wrapping. Doesn't that mean all of them mean text-wrap-mode: wrap? If so we probably should mention it in a consistent way. For example they can all start with "Text is wrapped in a way that..."

@dletorey dletorey requested a review from Josh-Cena June 11, 2024 11:07
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly recommend getting rid of the "in the same way that text-wrap-mode: wrap;" wording, unless I'm missing something. text-wrap-mode: wrap; does not say anything about how text is wrapped, only that it's wrapped. The two properties work in combination. It's even already mentioned above:

When wrapping is allowed (see text-wrap-mode), the text-wrap-style property is specified as a single keyword chosen from the list of values below.

files/en-us/web/css/text-wrap-style/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/text-wrap-style/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/text-wrap-style/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/text-wrap-style/index.md Outdated Show resolved Hide resolved
dletorey and others added 5 commits June 11, 2024 14:24
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks great

@Josh-Cena Josh-Cena merged commit 9081af4 into mdn:main Jun 11, 2024
8 checks passed
@dletorey dletorey deleted the 33549-text-wrap-style-Values branch June 11, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
2 participants