Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More prominently add examples of shift key changing KeyboardEvent.key #34117

Merged
merged 1 commit into from
Jun 13, 2024
Merged

More prominently add examples of shift key changing KeyboardEvent.key #34117

merged 1 commit into from
Jun 13, 2024

Conversation

Josh-Cena
Copy link
Member

Fix #33451.

It was sort of implied but made it really clear. Also made clear that Space is also just an example and not a special case.
@Josh-Cena Josh-Cena requested a review from a team as a code owner June 13, 2024 13:40
@Josh-Cena Josh-Cena requested review from wbamberg and removed request for a team June 13, 2024 13:40
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Jun 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URLs
wbamberg
wbamberg approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thank you @Josh-Cena !
@wbamberg wbamberg merged commit d4aeaf3 into mdn:main Jun 13, 2024
7 checks passed
@Josh-Cena Josh-Cena deleted the shift-key-event branch June 13, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
2 participants
@Josh-Cena @wbamberg