Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention complex selectors in :not #34405

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Mention complex selectors in :not #34405

merged 2 commits into from
Jun 26, 2024

Conversation

Josh-Cena
Copy link
Member

Fix #32880. Also updated related pages.
@Josh-Cena Josh-Cena requested a review from a team as a code owner June 25, 2024 15:55
@Josh-Cena Josh-Cena requested review from estelle and removed request for a team June 25, 2024 15:55
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed labels Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024 •
edited
Loading

Preview URLs

(comment last updated: 2024-06-25 18:23:04)
estelle
estelle approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just one suggestion, three time, to include the selector list as a link in the content instead of adding a see also. This improves the content with or without the suggestion.
files/en-us/web/css/_colon_is/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_not/index.md Outdated Show resolved Hide resolved
files/en-us/web/css/_colon_where/index.md Outdated Show resolved Hide resolved
@Josh-Cena @estelle
Apply suggestions from code review
69fb35d 
Co-authored-by: Estelle Weyl <estelle@openwebdocs.org>
@estelle estelle merged commit ea74075 into mdn:main Jun 26, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the selector-syntax branch June 26, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/s [PR only] 6-50 LoC changed
2 participants
@Josh-Cena @estelle