plugin pattern #1234
plugin pattern #1234
Conversation
Fix issue iluwatar#1218: Arrange, Act, Assert pattern (iluwatar#1221)
| title: Federated Identity | ||
| folder: federated-identity | ||
| permalink: /patterns/federated-identity/ | ||
| categories: Decoupling |
There was a problem hiding this comment.
| categories: Decoupling | |
| categories: Integration |
| permalink: /patterns/federated-identity/ | ||
| categories: Decoupling | ||
| tags: | ||
| - authentication |
There was a problem hiding this comment.
| - authentication | |
| - Decoupling |
| - authentication | ||
| --- | ||
| ## Also known as | ||
| claims-based access control |
There was a problem hiding this comment.
| claims-based access control | |
| Claims-based access control |
| claims-based access control | ||
|
|
||
| ## Intent | ||
| The Federated Identity pattern simplify development, minimize the requirement for user administration, and improve the user experience of the application. |
There was a problem hiding this comment.
I think we should also mention that it's about authentication, and especially integrating an external authentication mechanism
| <dependency> | ||
| <groupId>org.slf4j</groupId> | ||
| <artifactId>slf4j-simple</artifactId> | ||
| <version>1.8.0-beta4</version> |
There was a problem hiding this comment.
Please use the versions declared in the parent pom.xml. Check this elsewhere too.
| try{ | ||
| this.data = sdf.parse(data); | ||
| }catch (ParseException e){ | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
Please use logger for output. Check this elsewhere too.
| * <p> | ||
| */ | ||
| public Consumer(){ | ||
| this.name = "iluwater"; |
There was a problem hiding this comment.
| this.name = "iluwater"; | |
| this.name = "iluwatar"; |
| * when no get response from IdP. | ||
| */ | ||
| public void register() { | ||
| StringBuilder stringBuilder = new StringBuilder(); |
There was a problem hiding this comment.
In Java 11 we can use var to declare variables like this. See https://docs.oracle.com/en/java/javase/13/language/local-variable-type-inference.html
| private OpenApiPlugin getConfiguredOpenApiPlugin() { | ||
| Info info = new Info().version("1.0").description("RESTful Corpus Platform API"); | ||
| OpenApiOptions options = new OpenApiOptions(info) | ||
| .activateAnnotationScanningFor("com.iluwater.dederatedIdentity.IdP") |
There was a problem hiding this comment.
| .activateAnnotationScanningFor("com.iluwater.dederatedIdentity.IdP") | |
| .activateAnnotationScanningFor("com.iluwatar.dederatedIdentity.IdP") |
| } | ||
|
|
||
| @Test | ||
| public void test1(){ |
There was a problem hiding this comment.
Please use meaningful names for the tests so it's easy to see at a glance what it does
|
Please find the review comments above. When you're ready for another review please comment on this issue. Thanks! |
|
The correct issue this PR is implementing is #443 |
|
@jasciiz The pull request has remained inactive and is about to be closed. Please comment if you're still working on it. |
ohbus
added
the
status: stale
|
@jasciiz this PR has been inactive for a long time, we will close it soon if we do not see any updates. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Closed due to inactivity |
plugin pattern for issue #351