Interpreter: Optimize ReadVector/WriteVector by removing voffset lookups #18314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops these functions down the ranking of top functions by quite a bit in GTA, speedup at most 0.5% though. But enough of these small ones and they start adding up. Not sure why GTA falls back to the interpreter for these so much though. I guess some "uneaten" prefix..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today's microoptimization. The V() macro does a table lookup, which is kinda unnecessary.
Drops these functions down the ranking of top functions by quite a bit in GTA, speedup at most 0.5% though. But enough of these small ones and they start adding up.
Not sure why GTA falls back to the interpreter for these so much though. I guess some "uneaten" prefix..