Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: need to handle new-style loong64 relocs [1.21 backport] #67426

Closed
gopherbot opened this issue May 16, 2024 · 5 comments
Closed

cmd/link: need to handle new-style loong64 relocs [1.21 backport] #67426

gopherbot opened this issue May 16, 2024 · 5 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.21.12

Comments

@gopherbot
Copy link
Contributor

@cherrymui requested issue #63725 to be considered for backport to the next 1.21 minor release.

@gopherbot please backport this to Go 1.21. This causes test failures on the 1.21 release branch. Thanks.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label May 16, 2024
@gopherbot gopherbot mentioned this issue May 16, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 16, 2024
@gopherbot gopherbot added this to the Go1.21.11 milestone May 16, 2024
@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label May 22, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label May 22, 2024
@cagedmantis
Copy link
Contributor

Approved as this is a bug with no workaround.
@gopherbot gopherbot modified the milestones: Go1.21.11, Go1.21.12 Jun 4, 2024
@joedian
Copy link

joedian commented Jun 24, 2024

@cherrymui do we wan't to move forward with this backport?
@cherrymui
Copy link
Member

As far as I can tell, this backport is mostly to make tests pass on LUCI loong64 builder on the 1.21 release branch. However, it is currently passing https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/go1.21-linux-loong64 . I don't know what have changed, maybe the C toolchain on the builder? As it is currently passing, and Go 1.21 is EOL sometime soon, I'd be okay to leave it out for now. We can do it if it fails again.
@joedian
Copy link

joedian commented Jun 26, 2024

@cherrymui feel free to close the issue.
@cherrymui
Copy link
Member

As the tests are passing on the builder, we can close this for now. We can reopen if necessary.
@cherrymui cherrymui closed this as not planned Won't fix, can't repro, duplicate, stale Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
4 participants
@cagedmantis @gopherbot @cherrymui @joedian