Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(PnP): use require.resolve on setBabelPreset #14288

Merged
merged 2 commits into from
May 24, 2019
Merged

fix(PnP): use require.resolve on setBabelPreset #14288

merged 2 commits into from
May 24, 2019

Conversation

arcanis
Copy link
Contributor

@arcanis arcanis commented May 24, 2019

Description

When adding a new Babel plugin or preset to the configuration we first need to send it through require.resolve so that the package making the actual require call (Gatsby itself) can know where to find the package (it couldn't know otherwise just with the name except by relying on the hoisting).

Related Issues

n/a
@pieh pieh changed the title Uses require.resolve on setBabelPreset May 24, 2019
@pieh pieh merged commit 5e54afe into gatsbyjs:master May 24, 2019
@pieh pieh mentioned this pull request May 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@arcanis @pieh