Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings triggered in search.jsx #34

Open
mor10 opened this issue Jul 7, 2021 · 0 comments
Open

Warnings triggered in search.jsx #34

mor10 opened this issue Jul 7, 2021 · 0 comments

Comments

@mor10
Copy link

mor10 commented Jul 7, 2021

When booting this starter wile connected to a standard Shopify site, the following warning messages appear:

(...)/src/pages/search.jsx
115:9   warning  The 'productList' logical expression could make the dependencies of useEffect Hook (at line 127) change on every render. To fix this, wrap the initialization of 'productList' in its own useMemo() Hook  react-hooks/exhaustive-deps  
152:6   warning  React Hook React.useEffect has missing dependencies: 'fetchNextPage' and 'hasNextPage'. Either include them or remove the dependency array                                                                react-hooks/exhaustive-deps  
269:31  warning  React Hook useCallback received a function whose dependencies are unknown. Pass an inline function instead                                                                                                react-hooks/exhaustive-deps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant