Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding last_login to FAB for Superset #2124

Open
sfirke opened this issue Oct 4, 2023 · 1 comment
Open

Adding last_login to FAB for Superset #2124

sfirke opened this issue Oct 4, 2023 · 1 comment
Labels
enhancement

Comments

@sfirke
Copy link
Contributor

sfirke commented Oct 4, 2023

I'd like to implement apache/superset#22185 (comment), adding a last-logged-in field to Apache Superset. As far as I can tell, Superset imports UserModelView from FAB and uses it as-is. So if this modification to the default could happen in FAB, it would involve a tiny change, but if Superset broke from FAB here it would involve copying a lot of FAB code that would then be harder to maintain.

Is that correct? If so, are you open to adding last_login as a default displayed field in FAB? And is that addition as simple as I've laid out in my linked comment above?

Thanks for considering!
@dpgaspar
Copy link
Owner

Could be a nice addition as long as it fits well on the table, feel free to open a PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
2 participants
@dpgaspar @sfirke