Get loadingStrategy value from netlify.toml inputs, default to 'lazy' if not provided #98
Conversation
✅ Deploy Preview for netlify-plugin-cloudinary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Looks like the tests may need to be updated as well, will continue working on it tomorrow or Monday. |
…racters from paths * Fix tests breaking on Windows due to illegal character > in paths
* Windows path sep is a '\' which results in a cldAssetUrl containing URL encoding, causing tests to fail
|
thanks for fixing this 😅 im not sure how i never noticed it not working before, but glad you were able to get it set up working right! i only really have a question on the context of the posix fix, but it seems like it's to help make the project and tests more reliable from an environment perspective? |
…cted value for img loading attribute * Remove updateHtmlImagesToCloudinary() test because the default value of loadingStrategy is determined when the netlify.toml inputs are received, not when this function is called
|
great work here @gshel - thank you for the contribution! |
|
@all-contributors please add @gshel for code |
|
I've put up a pull request to add @gshel! 🎉 |
# [1.15.0](v1.14.0...v1.15.0) (2023-11-13) ### Features * Get loadingStrategy value from netlify.toml inputs, default to 'lazy' if not provided ([#98](#98)) ([8d68b05](8d68b05))
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Adds @gshel as a contributor for code. This was requested by colbyfayock [in this comment](#98 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
|
FYI 1.15.0 is available on Netlify! |
Description
loadingStrategy was not being read from the netlify.toml; this PR gets the value from the netlify.toml and if it doesn't exist, it defaults to
lazy.Issue Ticket Number
Fixes #97
Type of change
Checklist