Relative navigation always expects a search param?

[mirague]

Describe the bug

When using navigation (e.g. navigate / redirect) with a from and relative to, it seems TypeScript always complains about the search param being required, even if none of the routes define a validateSearch.

This example works at runtime, but TypeScript complains:

export const Route = createFileRoute('/posts/$postId')({
  beforeLoad: () => {
      // works, but TypeScript error about required "search" param
      throw redirect({
        from: Route.fullPath,
        to: '../',
      });
  }
});

Your Example Website or App

https://stackblitz.com/edit/tanstack-router-ycpp7o?file=src%2Froutes%2Fposts.%24postId.tsx

Steps to Reproduce the Bug or Issue

1. Open the posts.$postId.tsx file and go to the render function
2. Observe there's a TypeScript error, even though the actual code works

Expected behavior

I expect that if the to route doesn't provide a validateSearch, it's not a required prop and TypeScript doesn't complain.

Screenshots or Videos

Platform

• OS: macOS / Arc

Additional context

No response

[sepirak-nick]

Getting the same issue, upgrading from 1.29 to 1.40.

[schiller-manuel]

The error you see is caused by the trailingSlash router property:

https://tanstack.com/router/latest/docs/framework/react/api/router/RouterOptionsType#trailingslash-property

It defaults to never, so in that case you should use

        to: '..',

see https://stackblitz.com/edit/tanstack-router-xpxvgs?file=src%2Froutes%2Fposts.%24postId.tsx,src%2Fmain.tsx

If you changetrailingSlash to either preserve or always, you can use to: '../'.

see https://stackblitz.com/edit/tanstack-router-wxombr?file=src%2Froutes%2Fposts.%24postId.tsx

[mirague]

@schiller-manuel Thanks a lot for pointing it out, that was not clear to me from the TS error!

Do you think the type should be tweaked, either to be more permissive (allowing trailing slashes ../ in to param), or not include ../ in autosuggestion?

Typescript does auto-suggest ../:

[schiller-manuel]

Let's ask @chorobin about his opinion on this

[judgemavi]

Looks like in the latest version search param is required if route has validateSearch set.

I have zod schema with all properties set to optional but link and navigate still require search to be provided

[chorobin]

Let's ask @chorobin about his opinion on this

Yeah, we should at least not suggest '../' and suggest '..' instead

[chorobin]

Looks like in the latest version search param is required if route has validateSearch set.

I have zod schema with all properties set to optional but link and navigate still require search to be provided

Do you have an example where this is not working?

Generally the type logic for required/optional search params works off the basis that, if {} is assignable to your search params then it is optional