Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance Audit 2017: Beacon: Breakup page_ready callback #175

Open
nicjansma opened this issue Dec 22, 2017 · 0 comments
Open

Performance Audit 2017: Beacon: Breakup page_ready callback #175

nicjansma opened this issue Dec 22, 2017 · 0 comments

Comments

@nicjansma
Copy link

Each plugin may register for callbacks such as page_ready to add its data to the beacon.

When Boomerang fires the page_ready event to all listeners, it executes each serially.

We may want to investigate breaking up the callbacks (via setImmediate or something) to ensure long-running callbacks aren't all executed synchronously.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant