Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gif images play faster in iPhone 13 pro max #912

Open
RashVenkat6795 opened this issue Jul 22, 2022 · 8 comments
Open

Gif images play faster in iPhone 13 pro max #912

RashVenkat6795 opened this issue Jul 22, 2022 · 8 comments
Labels

Comments

@RashVenkat6795
Copy link

Describe the bug
GIF images which are at normal speed in phones, plays at very fast rate in iPhone 13 pro max

To Reproduce
Steps to reproduce the behavior if possible, or a link to a reproduction repo:
Play a gif image in iPhone 13 pro max

Expected behavior
GIF should play at normal speed

Screenshots

Dependency versions

  • React Native version: 0.64.0
  • React version: 17.0.1
  • React Native Fast Image version: 8.5.5
@nica0012
Copy link

I am also facing this issue.

I have experienced this from RN v0.64-0.66.

I can confirm gif speed is working as it should with the RN Component.

@safaiyeh
Copy link

safaiyeh commented Aug 9, 2022

You need to patch the SDWebImage dependency to 5.12

@Nehal-Sanklecha
Copy link

@safaiyeh why though?
Since it's happening specific to iPhone 13 pro max, it could be because of the refresh rate?

https://discussions.apple.com/thread/253799298

@safaiyeh
Copy link

@safaiyeh why though? Since it's happening specific to iPhone 13 pro max, it could be because of the refresh rate?

https://discussions.apple.com/thread/253799298

yup! its exactly that, SDWebImage 5.12 resolves the issue

@ScreamZ
Copy link

ScreamZ commented Oct 30, 2022

@DylanVann Sounds like a pretty simple update and very annoying, maybe you could have a look and help us on a quick fix ? :-) Thanks

@csaq5507
Copy link

Fixed in SDWebImage 5.15.3: SDWebImage/SDWebImage#3491
Till this package gets updated I made myself a patch:

/patches/react-native-fast-image+8.6.3.patch:

diff --git a/node_modules/react-native-fast-image/RNFastImage.podspec b/node_modules/react-native-fast-image/RNFastImage.podspec
index db0fada..0c0cce5 100644
--- a/node_modules/react-native-fast-image/RNFastImage.podspec
+++ b/node_modules/react-native-fast-image/RNFastImage.podspec
@@ -16,6 +16,6 @@ Pod::Spec.new do |s|
   s.source_files  = "ios/**/*.{h,m}"

   s.dependency 'React-Core'
-  s.dependency 'SDWebImage', '~> 5.11.1'
+  s.dependency 'SDWebImage', '~> 5.15.3'
   s.dependency 'SDWebImageWebPCoder', '~> 0.8.4'
 end

postinstall / patch-package, do yarn install, rm -rf Pods, rm Podfile.lock, pod install, works for me, idk if it breaks anything.

@jiangwei1995
Copy link

@DylanVann When will this bug be fixed?

@Gautham495
Copy link

Fixed in SDWebImage 5.15.3: SDWebImage/SDWebImage#3491 Till this package gets updated I made myself a patch:

/patches/react-native-fast-image+8.6.3.patch:

diff --git a/node_modules/react-native-fast-image/RNFastImage.podspec b/node_modules/react-native-fast-image/RNFastImage.podspec
index db0fada..0c0cce5 100644
--- a/node_modules/react-native-fast-image/RNFastImage.podspec
+++ b/node_modules/react-native-fast-image/RNFastImage.podspec
@@ -16,6 +16,6 @@ Pod::Spec.new do |s|
   s.source_files  = "ios/**/*.{h,m}"

   s.dependency 'React-Core'
-  s.dependency 'SDWebImage', '~> 5.11.1'
+  s.dependency 'SDWebImage', '~> 5.15.3'
   s.dependency 'SDWebImageWebPCoder', '~> 0.8.4'
 end

postinstall / patch-package, do yarn install, rm -rf Pods, rm Podfile.lock, pod install, works for me, idk if it breaks anything.

This is the exact answer! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8 participants