-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Progressive JPEG. #188
Comments
Thanks, glad you've found it useful. Progressive JPEG probably won't be supported anytime soon. It's not officially supported by either of the underlying native libraries. By not supported I mean I believe it will display them, but it will not display them progressively. I guess Progressive JPEG support is one nice feature of Fresco. |
Cool, thanks! I know it’s a big change, was it considered to use PinRemoteImage? It supports P-JPEG, and also – coming from iOS – I found it better to work with comparing to SDWebImage. |
Just looked on Fresco - yes, it looks great with their built in support for both progressive JPEGs and WebPs. Maybe it‘s worth checking the option to migrate to Fresco and PinRemoteImage. |
There isn't much chance of migrating to Fresco since problems with Fresco are why I made this in the first place. Last time I checked |
I understand, no problem. But just to mention: as far as I know – and according to their page also – |
Oh, I suppose it's just that the pod on master is in beta. I didn't catch that. I'll take a closer look. It does look nice, and having support for all those formats in one dependency is great. I'd also need to look into how to set headers, and how to preload. There is an issue open to moving to another library already because there are some issues I have with I guess the most challenging thing would be determining if it's actually faster. Relevant article: https://bpoplauschi.wordpress.com/2014/03/21/ios-image-caching-sdwebimage-vs-fastimage/ |
Oh, cool! |
@DylanVann any thoughts on this? |
Any news on this ? 😃 |
@DylanVann any new thoughts on this? I see that SDWebImage supports it (by passing |
Hi @DylanVann, thank you for the great library. |
@DylanVann any news? we are really looking forward to :) |
I need to do more tests, but It looks like just by adding
|
I’ve tried this approach, and it didn’t work well for me. I suggest moving to PinRemoteImage – I’ve tested it as a fork of this branch on Production for a while (switched the iOS depedency), and it works great |
On my side it is working just as expected, so I will keep the SDWebImageProgressiveLoad |
Hi!
Thanks for this awesome library!
I wanted to ask please: does the library support progressive JPEG?
Thanks!
The text was updated successfully, but these errors were encountered: