Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide alternative text for images #3468

Closed
eelzi-ONRR opened this issue Jun 7, 2024 · 9 comments
Closed

Provide alternative text for images #3468

eelzi-ONRR opened this issue Jun 7, 2024 · 9 comments
Assignees
Labels
Accessibility For all issues related to accessibility. P2: High This doesn’t prevent the site from being used, but needs to be addressed in the near term.

Comments

@eelzi-ONRR
Copy link
Collaborator

OCIO 2024 Report

Violation: Provide alternative text for images

Instances: 3
Occurrence: <1%
Severity: 10
Priority:

Notes/causes: This svg element does not have a mechanism that allows an accessible name value to be calculated

Location: https://revenuedata.doi.gov/fact-sheet

@eelzi-ONRR eelzi-ONRR added Accessibility For all issues related to accessibility. P2: High This doesn’t prevent the site from being used, but needs to be addressed in the near term. labels Jun 7, 2024
@lpgoldstein
Copy link
Collaborator

onrr logo should be marked decorative and not have alt text
Disbursements bar chart doesn't have alt text

@lpgoldstein
Copy link
Collaborator

@eelzi-ONRR Thanks I was checking with ANDI and that was one of the issues that popped up.

@eelzi-ONRR
Copy link
Collaborator Author

eelzi-ONRR commented Jun 17, 2024

According to the OCIO report it's the stacked bar charts causing the issue - you can find them by using inspect and searching for 0 0 436 130

It might just be the disbursement one - the report doesn't detail which chart(s) it is

@eelzi-ONRR
Copy link
Collaborator Author

The problem ANDI is marking isn't that it's decorative - it's that this image is an svg and svgs should have a title or ID instead of an alt text tag

https://accessibilityinsights.io/info-examples/web/svg-img-alt/

@lpgoldstein
Copy link
Collaborator

@eelzi-ONRR Thanks for clarification. I'll keep investigating and then propose solutions.

@lpgoldstein
Copy link
Collaborator

@greensomes We need some help with this one next sprint - we need to hide the svgs of each individual bar in each chart - there are 72 instances. I'd like to learn how to do this if possible. Also the alt text for the first chart - disbursements isn't showing up.

@greensomes
Copy link
Collaborator

This is fixed and can be reviewed in preview.

@lpgoldstein
Copy link
Collaborator

@greensomes looks great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accessibility For all issues related to accessibility. P2: High This doesn’t prevent the site from being used, but needs to be addressed in the near term.
3 participants