Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert expected arguments to driver values #31

Closed
l3pp4rd opened this issue Feb 17, 2016 · 0 comments
Closed

Convert expected arguments to driver values #31

l3pp4rd opened this issue Feb 17, 2016 · 0 comments
Assignees

Comments

@l3pp4rd
Copy link
Member

l3pp4rd commented Feb 17, 2016

Currently if expected argument is not converted to a supported driver.Value. That means the matching might be not exact or in some cases misleading and requires an user to expect already converted arguments.
Sqlmock should perform the same conversions as sql library for all expected arguments. That will be backward compatible and acting more as expected.

The changes may affect time.Time comparison, since it will be more strict.
The good outcome is that an error message for argument comparison will be more precise and will show exactly which argument did not match.

@l3pp4rd l3pp4rd self-assigned this Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant