Should method return default true, or false when meeting requirements [closed]

Question

Lets say I have simple IsSomething() method which checks, if object meets few requirements. Which approach is better?

public bool IsSomething()
{
    if (!MeetRequirementX()) return false;
    if (!MeetRequirementY()) return false;
    if (!MeetRequirementZ()) return false;

    return true;
}

Or

public bool IsSomething()
{
    if (MeetRequirementX() &&
       MeetRequirementY() &&
       MeetRequirementZ())
        return true;

    return false;
}

Answer 1

Your second example doesn't compile; you're using too much ifs.

If you would be looking what the compiler would make of it, there wouldn't be too much of a difference; the && operator short-circuits. Therefore, you can concentrate on what's more readable for the maintainers of the code (which could be a future you).

The shortest version would be

public bool IsSomething()
{
    return MeetRequirementX() && MeetRequirementY() && MeetRequirementZ();
}

which is fine if it's kind of obvious how these requirements combine into the desired result for IsSomething(). If that's not obvious, you'd better explain why each requirement is necessary with a comment, and then I'd prefer the following:

public bool IsSomething()
{
    // comment explaining why requirement X is necessary
    if (!MeetRequirementX()) return false;

    // comment explaining why requirement Y is necessary
    if (!MeetRequirementY()) return false;

    // comment explaining why requirement Z is necessary
    return MeetRequirementZ();
}

Or replace the last line with

    if (!MeetRequirementZ()) return false;

    return true;

if you prefer the symmetry of that.