commit | 027e67ac8ed42fab8416d2cb55dfba32be3fa633 | [log] [tgz] |
---|---|---|
author | Dirk Pranke <dpranke@google.com> | Sat Aug 03 04:01:14 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Sat Aug 03 04:01:14 2024 |
tree | f16114ec28209b1f894672d980e2ed36b5013a02 | |
parent | 515a6afe7fc082d6fe651679ac08a4cbd0674311 [diff] |
Revert "Reland "base_profiler_test_support_library: Don't link libc++ and libc++abi"" This reverts commit 28090b0aa1960957082d613f3181fa960fa6b4ab. Reason for revert: Broke the win-asan build again, this time differently: https://ci.chromium.org/ui/b/8740664034807324977 . I'm not sure how this got through the CQ Original change's description: > Reland "base_profiler_test_support_library: Don't link libc++ and libc++abi" > > This is a reland of commit 75f0ff2f430f3dd04a4693f43baad2b9633e62ab > > Original change's description: > > base_profiler_test_support_library: Don't link libc++ and libc++abi > > > > It's not necessary and makes base_profiler_test_support_library.so build > > faster. > > > > Moreover, a recent change to libc++abi makes it use `thread_local`. > > With that, base_profiler_test_support_library would be a binary that > > uses thread-local storage, which at least on macOS prevents dlclose() > > from unloading base_profiler_test_support_library.so, causing > > StackSamplingProfilerTest.UnloadedLibrary to fail. > > See bug for more details. > > > > This fixes that and unblocks rolling libc++abi. > > > > Change base_profiler_reparsing_test_support_library as well. > > that's not necessary for anything as far as I know, but it's nice > > if that target also builds faster, and if things are consistent. > > > > Bug: 351867703 > > Change-Id: I0177ef1fd3cdfe4457bab50aa9f8921e82af2bca > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5759749 > > Auto-Submit: Nico Weber <thakis@chromium.org> > > Reviewed-by: Arthur Eubanks <aeubanks@google.com> > > Commit-Queue: Arthur Eubanks <aeubanks@google.com> > > Commit-Queue: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1336769} > > Bug: 351867703 > Cq-Include-Trybots: luci.chromium.try:win-asan-rel > Change-Id: I59edfc781e521bbe38d3083bc212d3c870607e3e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5760770 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Erik Staab <estaab@chromium.org> > Commit-Queue: Dirk Pranke <dpranke@google.com> > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Reviewed-by: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1336903} Bug: 351867703 Change-Id: I951bab9ac3a7f7c096cc02078e7ed822988974da Cq-Include-Trybots: luci.chromium.try:win-asan-rel No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5760936 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/main@{#1336919}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.