| commit | 0c7f4af46515f2b12631122649bd39780943e3b2 | [log] [tgz] |
|---|---|---|
| author | Gavin Mak <gavinmak@google.com> | Tue Oct 26 00:31:27 2021 |
| committer | Gavin Mak <gavinmak@google.com> | Tue Oct 26 00:31:27 2021 |
| tree | 0bda689812008fd2f307df7e3331d083cae98b79 | |
| parent | 8b6232b5a7807428883ed4fc72d76f850c4bff41 [diff] |
Fix landingwidget with multiple versions When landingwidget renders multiple versions, the versions extend to the right without wrapping, breaking the UI. This change fixes this issue by representing multiple versions as list items instead of flat entries. Bug: 1263294 Change-Id: Iadee3d4faca74763360226dcd4ca9964d94a9a84
This plugin must be placed inside the Gerrit plugins directory:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit/plugins git clone https://chromium.googlesource.com/infra/gerrit-plugins/landingwidget
For running unit tests execute:
bazel test --test_output=all //plugins/landingwidget/web:karma_test
For checking or fixing eslint formatter problems run:
bazel test //plugins/landingwidget/web:lint_test bazel run //plugins/landingwidget/web:lint_bin -- --fix "$(pwd)/plugins/landingwidget/web"
For testing the plugin with Gerrit FE Dev Helper build the JavaScript bundle and copy it to the plugins/landingwidget folder:
bazel build //plugins/landingwidget/web:landingwidget cp -f bazel-bin/plugins/landingwidget/web/landingwidget.js plugins/landingwidget
and let the Dev Helper redirect from .+/plugins/landingwidget/static/landingwidget.js to http://localhost:8081/plugins_/plugins/landingwidget.js.
Note for local testing: this plugin fetches from an external site which may be blocked by CORS policy.