| commit | d29ca0c64e3a93a8b97f3af59a7da4761fcbc74f | [log] [tgz] |
|---|---|---|
| author | Mohamed Heikal <mheikal@chromium.org> | Thu Jul 18 20:33:17 2024 |
| committer | Mohamed Heikal <mheikal@chromium.org> | Thu Jul 18 20:33:17 2024 |
| tree | d1df6e903858a9919d870aff9ba080465f83dc01 | |
| parent | a28297906171087060b4c23d72d093b1d5e791b8 [diff] |
Set maximum decimal places to 1 in human readable delta 1.234 is confusing since the dot might be confused for a comma. Switch to limiting fractional digits to just 1 decimal place. Change-Id: If9a568821e3fda3ce58651e2355deaab02064ef4
The plugin queries the android-binary-size trybot for the current patchset on Gerrit, and gets the binary_size_plugin property. This property contains the metadata about the binary size metrics affected by the patchset in question. It then shows a table with the metric deltas + links to SuperSize output under the Checks tab.
This plugin is configured via the chromium-binary-size.config file present in the repo‘s refs/meta/config ref, as well as the same file in all repositories in the repo’s inheritance chain (up to and including All-Projects).
An example chromium-binary-size.config is below (this enables the plugin on the chromium/src repo using the android-binary-size trybot:
[host] gerrit = "chromium-review.googlesource.com" [repo "chromium/src"] builder = "android-binary-size" bucket = "try" project = "chromium"
All changes to chromium-binary-size.config files are instantly reflected. There is no caching period or need to restart the server.
This plugin must be placed inside the Gerrit plugins directory:
git clone --recurse-submodules https://gerrit.googlesource.com/gerrit cd gerrit/plugins git clone https://chromium.googlesource.com/infra/gerrit-plugins/chromium-binary-size
Run the commands below in web/.
For running Java unit tests execute:
make test_java
For running TypeScript unit tests execute:
make test
For checking or fixing eslint formatter problems run:
make lint_test make lint_fix
For testing the plugin with Gerrit FE Dev Helper the command below builds the JavaScript bundle and copies it to the plugins/chromium-binary-size folder:
make build
and let the Dev Helper redirect from .+/plugins/chromium-binary-size/static/chromium-binary-size.js to http://localhost:8081/plugins_/plugins/chromium-binary-size.js.