CHROMIUM: tests: Avoid complex TEST_TRUE()
I've seen one of these fail before, and the log output is suboptimal:
BAD: wrong value for WTERMSIG (status) == 9, expected TRUE got FALSE
at tests/test_initctl.c:11575 (test_no_dbus).
It'd be better if it dumped the value of `WTERMSIG (status)` for me;
that's what TEST_EQ(), TEST_LT(), etc., are for.
Fix up a bunch of cases, where TEST_TRUE() contains any extra boolean or
comparative logic (e.g., >=, <=, ==).
BUG=b:232122437
TEST=`FEATURES=test emerge-${BOARD} upstart`
Change-Id: Id3ed1e0eeab91db2f8c8f8ec2a4aecc56d9ebbd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/upstart/+/5431195
Tested-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
Commit-Queue: Brian Norris <briannorris@chromium.org>
2 files changed