Revert "UPSTREAM: fibocom: disable CPOL features in NL668"

This reverts commit 270432fe9c3cffb1101986c1ea563cf63e8f67f4.

Reason for revert: We'll disable AT over MBIM altogether in the NL668 instead.

Original change's description:
> UPSTREAM: fibocom: disable CPOL features in NL668
>
> Running +CPOL? in the NL668 using AT over MBIM seems to trigger a
> firmware crash. Let's disable the feature altogether in this device
> for this reason.
>
> (cherry picked from commit f7b351fc85f6cacb5d8b4483b052834be3aefe17)
>
> BUG=b:348124268,b:347448378
> TEST=Ensure no modem crash on vilboz/nl668 with Amarisoft SIM card
>
> Change-Id: I850ac15610dae198c5de0e62b1955d0588a58628
> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/modemmanager-next/+/5642555
> Tested-by: Aleksander Morgado <aleksandermj@google.com>
> Commit-Queue: Aleksander Morgado <aleksandermj@google.com>
> Reviewed-by: Andrew Lassalle <andrewlassalle@chromium.org>

BUG=b:348124268,b:347448378

Change-Id: Ia344eda5077200aa9bc72910e8a849551b960733
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/modemmanager-next/+/5646086
Commit-Queue: Eric Caruso <ejcaruso@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Tested-by: Aleksander Morgado <aleksandermj@google.com>
1 file changed
tree: 4687fd6752cce000c9f5b28768b9080d26d655e3
  1. build-aux/
  2. cli/
  3. data/
  4. docs/
  5. examples/
  6. include/
  7. introspection/
  8. libmm-glib/
  9. libqcdm/
  10. po/
  11. src/
  12. test/
  13. tools/
  14. vapi/
  15. .editorconfig
  16. .gitignore
  17. .gitlab-ci.yml
  18. AUTHORS
  19. COPYING
  20. COPYING.LIB
  21. DIR_METADATA
  22. meson.build
  23. meson_options.txt
  24. NEWS
  25. OWNERS
  26. PRESUBMIT.cfg
  27. README.chromium
  28. README.md
  29. RELEASING
  30. unblocked_terms.txt
README.md

ModemManager

ModemManager provides a unified high level API for communicating with mobile broadband modems, regardless of the protocol used to communicate with the actual device (Generic AT, vendor-specific AT, QCDM, QMI, MBIM...).

Getting Started

ModemManager uses the meson build system. Meson is likely available as a package from your Linux distrubtion, but if not please refer to the Meson project for installation instructions. Once you have Meson installed you'll probably want to install libmbim and libqmi which most modems require.

After dependencies are installed you can build ModemManager with:

$ meson setup build --prefix=/usr --buildtype=release
$ ninja -C build

And after a successful build, install with:

$ sudo ninja -C build install

Using

ModemManager is a system daemon and is not meant to be used directly from the command line. However, since it provides a DBus API, it is possible to use ‘dbus-send’ commands or the new ‘mmcli’ command line interface to control it from the terminal. The devices are queried from udev and automatically updated based on hardware events, although a manual re-scan can also be requested to look for RS232 modems.

Implementation

ModemManager is a DBus system bus activated service (meaning it's started automatically when a request arrives). It is written in C, using glib and gio. Several GInterfaces specify different features that the modems support, including the generic MMIfaceModem3gpp and MMIfaceModemCdma which provide basic operations for 3GPP (GSM, UMTS, LTE) or CDMA (CDMA1x, EV-DO) modems. If a given feature is not available in the modem, the specific interface will not be exported in DBus.

Plugins

Plugins are loaded on startup, and must implement the MMPlugin interface. It consists of a couple of methods which tell the daemon whether the plugin supports a port and to create custom MMBroadbandModem implementations. It most likely makes sense to derive custom modem implementations from one of the generic classes and just add (or override) operations which are not standard. There are multiple fully working plugins in the plugins/ directory that can be used as an example for writing new plugins. Writing new plugins is highly encouraged! The plugin API is open for changes, so if you're writing a plugin and need to add or change some public method, feel free to suggest it!

License

The ModemManager and mmcli binaries are both GPLv2+. The libmm-glib library is LGPLv2+.

Code of Conduct

Please note that this project is released with a Contributor Code of Conduct. By participating in this project you agree to abide by its terms, which you can find in the following link: https://www.freedesktop.org/wiki/CodeOfConduct

CoC issues may be raised to the project maintainers at the following address: modemmanager-devel-owner@lists.freedesktop.org