Overwrite default, menu and suggested-action buttons colors to match Chrome OS.
Mechanical CL that replaces 'color', 'background-color' and
'border-color' for default button, menu-button, text-button and
suggested-action button.
It also updates @borders (the default color for the borders of buttons
and other widgets) to #dadce0 to match Chrome OS's most recent buttons
spec.
This changes aim to make buttons (in the default state, i.e. not
hover, active or disabled) look more like Chrome OS.
Specifically:
- Buttons with no '.suggested-action' or '.destructive-action' class
now use:
- color: @suggestion_color;
- background-color: @theme_base_color;
- Buttons with the '.suggested-action' class now use:
- color: @theme_base_color;
- background-color: @suggestion_color;
- border-color: @borders;
- Buttons with 'menuitem.*button' or '.text-button' classes now use:
- color: @theme_text_color;
- background-color: @theme_base_color;
The rewrites were produced by a script that applies combinations of
regexes to search, filter, find and replace CSS while respecting
syntax as much as possible.
The modifications where made using the following set of rewrites,
applied using ./tools/rewriter.py:
Mod(r'button\.suggested-action',
anti=[r'\.destructive-action'],
remove=color(),
replace=r'\1@theme_base_color\3'),
Mod(r'button\.suggested-action',
anti=[r'\.destructive-action'],
remove=background_color(),
replace=r'\1@suggestion_color\3'),
Mod(r'button',
anti=[r'\..*\-action'],
remove=color(),
replace=r'\1@suggestion_color\3'),
Mod(r'button',
anti=[r'\..*\-action'],
remove=background_color(),
replace=r'\1@theme_base_color\3'),
Mod(r'button',
anti=[r'\..*\-action'],
remove=border_color(),
replace=r'\1@borders\3'),
Mod(r'menuitem.*button',
anti=[r'\..*\-action'],
remove=color(),
replace=r'\1@theme_text_color\3'),
Mod(r'text-button',
anti=[r'\..*\-action'],
remove=color(),
replace=r'\1@theme_text_color\3'),
Mod(r'menuitem.*button',
anti=[r'\..*\-action'],
remove=border_color(),
replace=r'\1@borders\3'),
Mod(r'text-button',
anti=[r'\..*\-action'],
remove=border_color(),
replace=r'\1@borders\3'),
Mod(r'menuitem.*button',
anti=[r'\..*\-action'],
remove=background_color(),
replace=r'\1@theme_base_color\3'),
Mod(r'text-button',
anti=[r'\..*\-action'],
remove=background_color(),
replace=r'\1@theme_base_color\3')
Bug: 822495
Change-Id: I68c8c92dd6f75efee220120751af1eba1e239adb
Reviewed-on: https://chromium-review.googlesource.com/1131016
Commit-Ready: Josh Pratt <jopra@chromium.org>
Tested-by: Josh Pratt <jopra@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
6 files changed
