| commit | 6269fce22dd40b022c098a3c5d0dcad67fe6d315 | [log] [tgz] |
|---|---|---|
| author | John Admanski <jadmanski@google.com> | Tue Jul 23 21:33:59 2024 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Aug 01 02:31:59 2024 |
| tree | 6a9c2bc1b6e82b0df73ee8dbaa5fd17b270a9159 | |
| parent | b6103e4a7087258c2abe9fdc76f4110befa1e67f [diff] |
cryptohome: Drop the AuthScanResult signal entirely This signal is superceded by the PrepareAuthFactorProgress signal. The fingerprint auth process was already updated to send the new signal in a previous change, this does the second half of the transition by removing the old signal. Note that this does _not_ remove the AuthScanResult proto message itself. This message is in fact a sub-message of the larger prepare signal and so it's not expected to go away entirely. BUG=b:347752239 TEST=CQ, unit tests Change-Id: If0e87327ed98a1db120845d7b21bb933d44fea48 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5734961 Tested-by: John Admanski <jadmanski@chromium.org> Reviewed-by: Zi Lin <lziest@google.com> Commit-Queue: John Admanski <jadmanski@chromium.org> NOKEYCHECK=True GitOrigin-RevId: cf3fb0879af3737f0e669df11ea9e8e4a884eb02
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.