| commit | 8e88b10a8ccf40230cf967ee7a7974953c642526 | [log] [tgz] |
|---|---|---|
| author | Kevin Lin <kevinptt@chromium.org> | Wed Jul 10 08:44:40 2024 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Jul 10 13:29:28 2024 |
| tree | 8f1884dbc8a004fb7faa77f609311ecc00c86b03 | |
| parent | 349fbc84c55930e84bb098ac37b343f4605687a5 [diff] |
Revert "rmad: Reset FPS data in finalize stage" This reverts commit b3291ba02fefb3b4865bafef66722ad0e089750a. Reason for revert: This step needs access permission to /dev/cros_fp. Will move the function to the executor and mount /dev/cros_fp. Also need to drop RMAD_FINALIZE_ERROR_CANNOT_RESET_FPS as it is not recognized by Shimless frontend. Original change's description: > rmad: Reset FPS data in finalize stage > > The command resetting FPS data, bio_wash, requires to be run with > HWWP=1. This CL moves resetting FPS data step to the enabling HWWP step > in the finalize stage. > > BUG=b:339348125 > TEST=FEATURES=test emerge-brya rmad > TEST=Execute full Shimless RMA process > > Change-Id: I32ecad31b8d0496fc06a53fb7c05a197ee3817f6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5641975 > Reviewed-by: Jeff Lin <jeffulin@google.com> > Tested-by: Kevin Lin <kevinptt@chromium.org> > Commit-Queue: Kevin Lin <kevinptt@chromium.org> BUG=b:339348125 Change-Id: Ie7e583e6efe4686bc08d282a42ff17909eb07e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5690619 Auto-Submit: Kevin Lin <kevinptt@chromium.org> Reviewed-by: Jeff Lin <jeffulin@google.com> Tested-by: Kevin Lin <kevinptt@chromium.org> Commit-Queue: Kevin Lin <kevinptt@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 1110321a36260a033e9bf794b73939b783ec3f76
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.