commit | 871c7115752ff7d5753a065190e3ba0e6fc9c8c5 | [log] [tgz] |
---|---|---|
author | Eric Caruso <ejcaruso@chromium.org> | Wed Jul 10 16:42:08 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Thu Jul 11 19:00:02 2024 |
tree | fcfa3f6fe5fb93fc90807a43913d45aefedd4eb2 | |
parent | 8e88b10a8ccf40230cf967ee7a7974953c642526 [diff] |
modemfwd: add Task keys and constants to system_api BUG=b:315488486 TEST=deploy to DUT and watch properties Change-Id: I96c55a8dfcf74b534a9d8da640cad8fb1b7fc075 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5689695 Commit-Queue: Eric Caruso <ejcaruso@chromium.org> Tested-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-by: Ujjwal Pande <ujjwalpande@google.com> NOKEYCHECK=True GitOrigin-RevId: 291cd8b3dbb9ee6cd33f03cae25322a9fc40fefc
This directory (platform2/system_api
) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.