| commit | 349fbc84c55930e84bb098ac37b343f4605687a5 | [log] [tgz] |
|---|---|---|
| author | John Admanski <jadmanski@google.com> | Tue Jul 09 20:56:53 2024 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Jul 10 01:23:21 2024 |
| tree | 320d6295e27e02b3b229ed9e2fb2d3304531e4ad | |
| parent | 06e96bb7769e17184aa45a2f3170aea96214fc63 [diff] |
cryptohome: Delete rpc.proto copy of CryptohomeErrorCode This copy of the error codes is obsolete, only the one in the user_data_auth package should be used. This does require deleting a few stray references to the rpc.proto versions from a few unit tests. This bundles together the API change and the cryptohome change because the API changes are heavily coupled to the static asserts in cryptohome and it doesn't really make sense to separate the removal. BUG=b:135984863 TEST=built all cryptohome code TEST=built chromium code with changes applied Change-Id: I65de67412cc5fafbae1789e37fd835e8ba4baa2e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5690410 Commit-Queue: John Admanski <jadmanski@chromium.org> Tested-by: John Admanski <jadmanski@chromium.org> Reviewed-by: Zi Lin <lziest@google.com> NOKEYCHECK=True GitOrigin-RevId: 2dff352b7a9cedb386bc731856db9b19dc050129
This directory (platform2/system_api) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.