commit | 06e96bb7769e17184aa45a2f3170aea96214fc63 | [log] [tgz] |
---|---|---|
author | Sergey Poromov <poromov@chromium.org> | Fri Jul 05 11:04:04 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Tue Jul 09 08:33:10 2024 |
tree | b684528461d1d165e02aa9a5c9cc6005c32ec824 | |
parent | f58414cfb784237988b52db5cd049b005732547a [diff] |
system_api: Add missing SetUserDataStorageWriteEnabled const. Adding const for a new cryptohome D-Bus method. BUG=b:342564051 TEST=builds Change-Id: Ia7c2e1f19b80df6a34ebc2a69eef145c711b897e Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/5675882 Tested-by: Sergey Poromov <poromov@chromium.org> Reviewed-by: Betul Soysal <betuls@google.com> Commit-Queue: Sergey Poromov <poromov@chromium.org> Auto-Submit: Sergey Poromov <poromov@chromium.org> NOKEYCHECK=True GitOrigin-RevId: 5e43a2cc5d765b77d847262aecef4418118bc35f
This directory (platform2/system_api
) contains constants and definitions like D-Bus service names that are shared between Chromium and Chromium OS.
This directory is only for things like headers and .proto files. No implementation should be added.
When writting a .proto file make sure to use:
option optimize_for = LITE_RUNTIME;
This will force usage of a lite protobuf instead of a full/heavy weight protobuf. The browser only links against the light version, so you will get cryptic link errors about missing parts of Message if you define a protobuf here and then try to use it in Chrome. Currently CrOS links against the full protobuffer library, but that might change in the future.
When declaring a protobuf, avoid use of required unless it is exactly what you mean. “Required is Forever” and very rarely should actually be used. Consult Protocol Buffer Basics: C++ for a detailed of this issue.