Google Git
Sign in
chromium / chromium / tools / depot_tools / refs/heads/main
commit40cece20d0eaae6fd41fcbc008480e71f2e3aed9[log] [tgz]
authorAllen Li <ayatane@chromium.org>Sat Aug 03 00:09:25 2024
committerLUCI CQ <infra-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Aug 03 00:09:25 2024
tree61ec5b3e1e7059fc20b4be3fe51d53012f73d5fd
parent0cb94fcfa962f2409479e7c0fa68926fc8ebc1c2 [diff]
[git_cl] Fix some type checking errors

Bug: b/351071334
Change-Id: I15b8c7658c5959dbf88168e278525c2b8e2e4b2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5754255
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
Commit-Queue: Allen Li <ayatane@chromium.org>
1 file changed
tree: 61ec5b3e1e7059fc20b4be3fe51d53012f73d5fd
  1. bootstrap/
  2. fetch_configs/
  3. hooks/
  4. infra/
  5. man/
  6. metadata/
  7. python-bin/
  8. python2-bin/
  9. recipes/
  10. testing_support/
  11. tests/
  12. third_party/
  13. win_toolchain/
  14. zsh-goodies/
  15. bazel ⇨ bazel.py
  16. cbuildbot ⇨ cros
  17. cros_sdk ⇨ cros
  18. gerrit ⇨ cros
  19. .cipd_impl.ps1
  20. .flake8
  21. .gitattributes
  22. .gitignore
  23. .isort.cfg
  24. .style.yapf
  25. .vpython3
  26. auth.py
  27. autoninja
  28. autoninja.bat
  29. autoninja.py
  30. bazel.py
  31. bb
  32. bb.bat
  33. black
  34. bootstrap_python3
  35. breakpad.py
  36. BUILD_OWNERS
  37. build_telemetry
  38. build_telemetry.bat
  39. build_telemetry.py
  40. cipd
  41. cipd.bat
  42. cipd_bin_setup.bat
  43. cipd_bin_setup.sh
  44. cipd_client_version
  45. cipd_client_version.digests
  46. cipd_manifest.txt
  47. cipd_manifest.versions
  48. cipd_manifest_cros_python2.txt
  49. cipd_manifest_cros_python2.versions
  50. clang-format
  51. clang-format.bat
  52. clang_format.py
  53. codereview.settings
  54. compile_single_file
  55. compile_single_file.bat
  56. compile_single_file.py
  57. cpplint.bat
  58. cpplint.py
  59. cpplint_chromium.py
  60. cros
  61. CROS_OWNERS
  62. cros_python2.vpython
  63. detect_host_arch.py
  64. DIR_METADATA
  65. dirmd
  66. dirmd.bat
  67. download_from_google_storage
  68. download_from_google_storage.bat
  69. download_from_google_storage.py
  70. ensure_bootstrap
  71. fetch
  72. fetch.bat
  73. fetch.py
  74. gclient
  75. gclient-new-workdir.py
  76. gclient.bat
  77. gclient.py
  78. gclient_completion.sh
  79. gclient_eval.py
  80. gclient_paths.py
  81. gclient_scm.py
  82. gclient_utils.py
  83. gerrit_client.py
  84. gerrit_util.py
  85. git-cache
  86. git-cl
  87. git-credential-luci
  88. git-credential-luci.bat
  89. git-crrev-parse
  90. git-drover
  91. git-find-releases
  92. git-footers
  93. git-freeze
  94. git-gs
  95. git-hyper-blame
  96. git-map
  97. git-map-branches
  98. git-mark-merge-base
  99. git-nav-downstream
  100. git-nav-upstream
  101. git-new-branch
  102. git-number
  103. git-rebase-update
  104. git-rename-branch
  105. git-reparent-branch
  106. git-retry
  107. git-runhooks
  108. git-squash-branch
  109. git-squash-branch-tree
  110. git-thaw
  111. git-upstream-diff
  112. git_auth.py
  113. git_cache.py
  114. git_cl.py
  115. git_cl_completion.sh
  116. git_common.py
  117. git_completion.sh
  118. git_dates.py
  119. git_find_releases.py
  120. git_footers.py
  121. git_freezer.py
  122. git_hyper_blame.py
  123. git_map.py
  124. git_map_branches.py
  125. git_mark_merge_base.py
  126. git_nav_downstream.py
  127. git_new_branch.py
  128. git_number.py
  129. git_rebase_update.py
  130. git_rename_branch.py
  131. git_reparent_branch.py
  132. git_retry.py
  133. git_squash_branch.py
  134. git_squash_branch_tree.py
  135. git_upstream_diff.py
  136. gn
  137. gn.bat
  138. gn.py
  139. gn_helper.py
  140. google-java-format
  141. google-java-format.bat
  142. google_java_format.py
  143. gsutil.py
  144. gsutil.py.bat
  145. gsutil.vpython3
  146. isort
  147. led
  148. led.bat
  149. LICENSE
  150. lockfile.py
  151. luci-auth
  152. luci-auth.bat
  153. LUCI_OWNERS
  154. lucicfg
  155. lucicfg.bat
  156. mac_toolchain
  157. metrics.py
  158. metrics.README.md
  159. metrics_utils.py
  160. my_activity.py
  161. newauth.py
  162. ninja
  163. ninja.bat
  164. ninja.py
  165. ninjalog_uploader.py
  166. OWNERS
  167. owners_client.py
  168. owners_finder.py
  169. pinpoint
  170. pinpoint.bat
  171. post_build_ninja_summary.py
  172. PRESUBMIT.py
  173. presubmit_canned_checks.py
  174. presubmit_diff.py
  175. presubmit_support.py
  176. prpc
  177. prpc.bat
  178. pylint-2.17
  179. pylint-2.17.bat
  180. pylint-2.6
  181. pylint-2.6.bat
  182. pylint-2.7
  183. pylint-2.7.bat
  184. pylint_main.py
  185. pylintrc
  186. pylintrc-2.17
  187. python_runner.sh
  188. rdb
  189. rdb.bat
  190. rdb_wrapper.py
  191. README.gclient.md
  192. README.git-cl.md
  193. README.md
  194. reclient_helper.py
  195. RECLIENT_OWNERS
  196. reclientreport
  197. reclientreport.bat
  198. reclientreport.py
  199. repo
  200. repo_launcher
  201. roll-dep
  202. roll-dep.bat
  203. roll_dep.py
  204. rustfmt.py
  205. scm.py
  206. setup_color.py
  207. siso
  208. siso.bat
  209. siso.py
  210. split_cl.py
  211. subcommand.py
  212. subprocess2.py
  213. swift-format
  214. swift_format.py
  215. update_depot_tools
  216. update_depot_tools.bat
  217. update_depot_tools_toggle.py
  218. upload_metrics.py
  219. upload_to_google_storage.py
  220. upload_to_google_storage_first_class.py
  221. utils.py
  222. vpython3
  223. vpython3.bat
  224. WATCHLISTS
  225. watchlists.py
  226. whitespace.txt
  227. win32imports.py
  228. yapf
  229. yapf.bat
README.md

depot_tools

Tools for working with Chromium development. It requires python 3.8.

Tools

The most important tools are:

  • fetch: A gclient wrapper to checkout a project. Use fetch --help for more details.
  • gclient: A meta-checkout tool. Think repo or git submodules, except that it support OS-specific rules, e.g. do not checkout Windows only dependencies when checking out for Android. Use gclient help for more details and README.gclient.md.
  • git cl: A code review tool to interact with Rietveld or Gerrit. Use git cl help for more details and README.git-cl.md.
  • roll-dep: A gclient dependency management tool to submit a dep roll, updating a dependency to a newer revision.

There are a lot of git utilities included.

Updating

depot_tools updates itself automatically when running gclient tool. To disable auto update, set the environment variable DEPOT_TOOLS_UPDATE=0 or run ./update_depot_tools_toggle.py --disable.

To update package manually, run update_depot_tools.bat on Windows, or ./update_depot_tools on Linux or Mac.

On Windows only, running gclient will install git and python.

Contributing

To contribute change for review:

git new-branch <somename>
# Hack
git add .
git commit -a -m "Fixes goat teleporting"
# find reviewers
git cl owners
git log -- <yourfiles>

# Request a review.
git cl upload -r reviewer1@chromium.org,reviewer2@chromium.org --send-mail

# Edit change description if needed.
git cl desc

# If change is approved, flag it to be committed.
git cl set-commit

# If change needs more work.
git rebase-update
...
git cl upload -t "Fixes goat teleporter destination to be Australia"

See also open bugs, open reviews, forum or report problems.

cpplint.py

Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We will figure out a long-term strategy via issue https://crbug.com/916550.

Note that the cpplint.py here is also used by the Tricium analyzer, so if the cpplint.py here changes, we should also update the copy used there.